From patchwork Mon Sep 26 16:38:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 12989133 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A542BC6FA90 for ; Mon, 26 Sep 2022 17:24:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230469AbiIZRYH (ORCPT ); Mon, 26 Sep 2022 13:24:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231172AbiIZRXq (ORCPT ); Mon, 26 Sep 2022 13:23:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADDF112F744 for ; Mon, 26 Sep 2022 09:38:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3C03160FDA for ; Mon, 26 Sep 2022 16:38:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55D70C433C1; Mon, 26 Sep 2022 16:38:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664210329; bh=x+jvZpAQD49OnAwK2gXuF648cs1JpNA51XaU06fHRko=; h=From:To:Cc:Subject:Date:From; b=irO3GCstSsAxexQjQ998Ak1sCvx9tc2h2pk/KWmgtqtgzSXTBv8/szsWAte8A7R8t ChJAWTssHhD01E0RkLPWZ4mvMr1X2Ar+9jAC2UipdjP6BIh+nSovudhAmQ1zLxKyl+ gN/4oYEQXa07kn2szA4cKsvw8YDxPrErnLRMuTYJ/bv1Bu7ynW5m8K8b7eapdLFm4l HR7dhb3+Iumc0LdBrJ8NknHQEN63ahmgqCFIn/lPVbny7NkkP4qq5q2eCMr4Ly/MNQ +Olzhrrds5nQA1rS/sILRQ2lqwbH7Pg5OqAauWlWdFEvPfpw4qbL/XyDtuOKV3MwlX ZuJsJkZthuuhA== From: Jeff Layton To: chuck.lever@oracle.com Cc: linux-nfs@vger.kernel.org Subject: [PATCH 0/4] nfsd: minor cleanup and sanity check patches for nfsd Date: Mon, 26 Sep 2022 12:38:43 -0400 Message-Id: <20220926163847.47558-1-jlayton@kernel.org> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Chuck, While hunting for some bugs, I found some warts that the first two patches clean up. I also added some sanity checks when freeing delegations or queueing up a CB_RECALL. Your call on whether you want to accept those. These should apply cleanly to your for-next branch, but the last patch may need to be adjusted when Dai fixes up his patch. Cheers, Jeff Layton (4): nfsd: only fill out return pointer on success in nfsd4_lookup_stateid nfsd: fix comments about spinlock handling with delegations nfsd: make nfsd4_run_cb a bool return function nfsd: extra checks when freeing delegation stateids fs/nfsd/nfs4callback.c | 14 ++++++++++++-- fs/nfsd/nfs4state.c | 26 +++++++++++++++----------- fs/nfsd/state.h | 2 +- 3 files changed, 28 insertions(+), 14 deletions(-)