[v6,0/4] nfsd: clean up refcounting in the filecache

Message

Jeff Layton Nov. 2, 2022, 6:44 p.m. UTC

v6:
- merge the LRU handling fixes into the refcount fixing patches
- call nfsd_file_close_inode from the notifier callbacks, which
  decrements and queues any objects to be freed by the disposal
  workqueue job

Only two main changes in this patchset. I folded two patches together
to avoid a problem that Chuck hit while testing. The other significant
change is to have the notifier callbacks use the disposal workqueue
job instead of freeing things themselves. Those don't need to be done
synchronously.

Jeff Layton (4):
  nfsd: remove the pages_flushed statistic from filecache
  nfsd: reorganize filecache.c
  nfsd: rework refcounting in filecache
  nfsd: fix up the filecache laundrette scheduling

 fs/nfsd/filecache.c | 406 +++++++++++++++++++++++---------------------
 fs/nfsd/filecache.h |   1 +
 fs/nfsd/trace.h     |  11 +-
 3 files changed, 222 insertions(+), 196 deletions(-)

Comments

Chuck Lever Nov. 3, 2022, 7:19 p.m. UTC | #1

Hi Jeff-

> On Nov 2, 2022, at 2:44 PM, Jeff Layton <[e-mail]> wrote:
> 
> v6:
> - merge the LRU handling fixes into the refcount fixing patches
> - call nfsd_file_close_inode from the notifier callbacks, which
>  decrements and queues any objects to be freed by the disposal
>  workqueue job
> 
> Only two main changes in this patchset. I folded two patches together
> to avoid a problem that Chuck hit while testing. The other significant
> change is to have the notifier callbacks use the disposal workqueue
> job instead of freeing things themselves. Those don't need to be done
> synchronously.
> 
> Jeff Layton (4):
>  nfsd: remove the pages_flushed statistic from filecache
>  nfsd: reorganize filecache.c
>  nfsd: rework refcounting in filecache
>  nfsd: fix up the filecache laundrette scheduling
> 
> fs/nfsd/filecache.c | 406 +++++++++++++++++++++++---------------------
> fs/nfsd/filecache.h |   1 +
> fs/nfsd/trace.h     |  11 +-
> 3 files changed, 222 insertions(+), 196 deletions(-)

Tested and applied v6 to nfsd's for-next. Thanks!


--
Chuck Lever