[0/6,v2] support admin-revocation of v4 state

Message ID	20231101010049.27315-1-neilb@suse.de (mailing list archive)
Headers	show Return-Path: <linux-nfs-owner@vger.kernel.org> From: NeilBrown <neilb@suse.de> To: Chuck Lever <chuck.lever@oracle.com>, Jeff Layton <jlayton@kernel.org> Cc: linux-nfs@vger.kernel.org, Olga Kornievskaia <kolga@netapp.com>, Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com> Subject: [PATCH 0/6 v2] support admin-revocation of v4 state Date: Wed, 1 Nov 2023 11:57:07 +1100 Message-ID: <20231101010049.27315-1-neilb@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	support admin-revocation of v4 state \| expand [0/6,v2] support admin-revocation of v4 state [1/6] nfsd: prepare for supporting admin-revocation of state [2/6] nfsd: allow admin-revoked state to appear in /proc/fs/nfsd/clients/*/states [3/6] nfsd: allow admin-revoked NFSv4.0 state to be freed. [4/6] nfsd: allow lock state ids to be revoked and then freed [5/6] nfsd: allow open state ids to be revoked and then freed [6/6] nfsd: allow delegation state ids to be revoked and then freed

Message ID

20231101010049.27315-1-neilb@suse.de (mailing list archive)

Headers

From: NeilBrown <neilb@suse.de>
To: Chuck Lever <chuck.lever@oracle.com>,
        Jeff Layton <jlayton@kernel.org>
Cc: linux-nfs@vger.kernel.org, Olga Kornievskaia <kolga@netapp.com>,
        Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Subject: [PATCH 0/6 v2] support admin-revocation of v4 state
Date: Wed,  1 Nov 2023 11:57:07 +1100
Message-ID: <20231101010049.27315-1-neilb@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

support admin-revocation of v4 state | expand

Message

NeilBrown Nov. 1, 2023, 12:57 a.m. UTC

This set fixes two issues found by kernel test robot
1/ nfsd4_revoke_states() needs to be defined when not CONFIG_NFSD_V4
2/ nfs40_last_revoke is larger than a mechine word in 32 bit configs,
   so needs protection - use nn->client_lock which is already taken when
   nfs40_last_revoke is accessed.

NeilBrown

Comments

Jeff Layton Nov. 2, 2023, 11:29 a.m. UTC | #1

On Wed, 2023-11-01 at 11:57 +1100, NeilBrown wrote:
> This set fixes two issues found by kernel test robot
> 1/ nfsd4_revoke_states() needs to be defined when not CONFIG_NFSD_V4
> 2/ nfs40_last_revoke is larger than a mechine word in 32 bit configs,
>    so needs protection - use nn->client_lock which is already taken when
>    nfs40_last_revoke is accessed.
> 
> NeilBrown
> 

In general, the series looks like something reasonable to do (and
something admins would welcome). I have some (long standing) concerns
around the sc_type value though that I think we probably need to address
prior to or in conjunction with this set.

Cheers,