[v2,0/4] SUNRPC: Various RCU fixes

Message

Anna Schumaker Dec. 4, 2023, 8:25 p.m. UTC

From: Anna Schumaker <[e-mail]>

These are various fixes that I found after turning on CONFIG_LOCKDEP,
CONFIG_PROVE_RCU, and CONFIG_DEBUG_ATOMIC_SLEEP. I didn't hit any issues
when testing against a Linux server, but running against Netapp with pNFS
had several different lockdep & rcu related spews show up in my dmesg
(and that's just from running cthon, not even xfstests). These patches fix
all the issues that I found, and have a couple extra cleanups that I noticed
along the way.

Changes in v2:
* Have rpc_xprt_switch_has_addr() unconditionally take the
  rcu_read_lock(), since we don't need to worry about this deadlocking
  if the lock is already held by the caller.

Thoughts?
Anna


Anna Schumaker (4):
  SUNRPC: Clean up unused variable in rpc_xprt_probe_trunked()
  SUNRPC: Remove unused function rpc_clnt_xprt_switch_put()
  SUNRPC: Create a helper function for accessing the rpc_clnt's
    xprt_switch
  SUNRPC: Fix a suspicious RCU usage warning

 include/linux/sunrpc/clnt.h |  1 -
 net/sunrpc/clnt.c           | 45 +++++++++++++++++--------------------
 net/sunrpc/xprtmultipath.c  | 17 ++++++++++++--
 3 files changed, 36 insertions(+), 27 deletions(-)