mbox series

[0/4,v3] nfsd: fix deadlock in move_to_close_lru()

Message ID 20240304224714.10370-1-neilb@suse.de (mailing list archive)
Headers show
Series nfsd: fix deadlock in move_to_close_lru() | expand

Message

NeilBrown March 4, 2024, 10:45 p.m. UTC 
This is very similar to v2 with:
 - first two patches swapped
 - while(1) loop changed to "goto retry"
 - add a comment to patch 3
 - rebase on nfsd-next
 - rb from Jeff added.

NeilBrown

 [PATCH 1/4] nfsd: move nfsd4_cstate_assign_replay() earlier in open
 [PATCH 2/4] nfsd: perform all find_openstateowner_str calls in the
 [PATCH 3/4] nfsd: replace rp_mutex to avoid deadlock in
 [PATCH 4/4] nfsd: drop st_mutex_mutex before calling

Comments

Jeff Layton March 5, 2024, 3:18 p.m. UTC | #1 
On Tue, 2024-03-05 at 09:45 +1100, NeilBrown wrote:
> This is very similar to v2 with:
>  - first two patches swapped
>  - while(1) loop changed to "goto retry"
>  - add a comment to patch 3
>  - rebase on nfsd-next
>  - rb from Jeff added.
> 
> NeilBrown
> 
>  [PATCH 1/4] nfsd: move nfsd4_cstate_assign_replay() earlier in open
>  [PATCH 2/4] nfsd: perform all find_openstateowner_str calls in the
>  [PATCH 3/4] nfsd: replace rp_mutex to avoid deadlock in
>  [PATCH 4/4] nfsd: drop st_mutex_mutex before calling

You can add this to the set. Nice work!

Reviewed-by: Jeff Layton <jlayton@kernel.org>