[RESEND,v2,0/3] nfs: Improve throughput for random buffered writes

Message

Jan Kara July 1, 2024, 10:50 a.m. UTC

[Resending because of messed up mailing list address]

Hello,

this is second revision of my patch series improving NFS throughput for
buffered writes.

Changes since v1:
* Added Reviewed-by tags
* Made sleep waiting for congestion to resolve killable

Original cover letter below:

I was thinking how to best address the performance regression coming from
NFS write congestion. After considering various options and concerns raised
in the previous discussion, I've got an idea for a simple option that could
help to keep the server more busy - just mimick what block devices do and
block the flush worker waiting for congestion to resolve instead of aborting
the writeback. And it actually helps enough that I don't think more complex
solutions are warranted at this point.

This patch series has two preparatory cleanups and then a patch implementing
this idea.

								Honza

Previous versions:
Link: http://lore.kernel.org/r/[e-mail] # v1

Comments

Jan Kara July 17, 2024, 3:58 p.m. UTC | #1

Ping? I don't see these patches being in NFS git tree. Did they fall
through the cracks?

								Honza

On Mon 01-07-24 12:50:45, Jan Kara wrote:
> [Resending because of messed up mailing list address]
> 
> Hello,
> 
> this is second revision of my patch series improving NFS throughput for
> buffered writes.
> 
> Changes since v1:
> * Added Reviewed-by tags
> * Made sleep waiting for congestion to resolve killable
> 
> Original cover letter below:
> 
> I was thinking how to best address the performance regression coming from
> NFS write congestion. After considering various options and concerns raised
> in the previous discussion, I've got an idea for a simple option that could
> help to keep the server more busy - just mimick what block devices do and
> block the flush worker waiting for congestion to resolve instead of aborting
> the writeback. And it actually helps enough that I don't think more complex
> solutions are warranted at this point.
> 
> This patch series has two preparatory cleanups and then a patch implementing
> this idea.
> 
> 								Honza
> 
> Previous versions:
> Link: http://lore.kernel.org/r/[e-mail] # v1
>

Anna Schumaker July 17, 2024, 5:44 p.m. UTC | #2

Hi Jan,

On Wed, Jul 17, 2024 at 11:58 AM Jan Kara <[e-mail]> wrote:
>
> Ping? I don't see these patches being in NFS git tree. Did they fall
> through the cracks?
>

I have these patches in my tree starting with this commit:
http://git.linux-nfs.org/?p=anna/linux-nfs.git;a=commit;h=37d4159dd25ade59ce0fecc75984240e5f7abc14

I hope this helps!
Anna

>                                                                 Honza
>
> On Mon 01-07-24 12:50:45, Jan Kara wrote:
> > [Resending because of messed up mailing list address]
> >
> > Hello,
> >
> > this is second revision of my patch series improving NFS throughput for
> > buffered writes.
> >
> > Changes since v1:
> > * Added Reviewed-by tags
> > * Made sleep waiting for congestion to resolve killable
> >
> > Original cover letter below:
> >
> > I was thinking how to best address the performance regression coming from
> > NFS write congestion. After considering various options and concerns raised
> > in the previous discussion, I've got an idea for a simple option that could
> > help to keep the server more busy - just mimick what block devices do and
> > block the flush worker waiting for congestion to resolve instead of aborting
> > the writeback. And it actually helps enough that I don't think more complex
> > solutions are warranted at this point.
> >
> > This patch series has two preparatory cleanups and then a patch implementing
> > this idea.
> >
> >                                                               Honza
> >
> > Previous versions:
> > Link: http://lore.kernel.org/r/[e-mail] # v1
> >
> --
> Jan Kara <[e-mail]>
> SUSE Labs, CR
>

Jan Kara July 18, 2024, 9:47 a.m. UTC | #3

Hi Anna!

On Wed 17-07-24 13:44:57, Anna Schumaker wrote:
> On Wed, Jul 17, 2024 at 11:58 AM Jan Kara <[e-mail]> wrote:
> >
> > Ping? I don't see these patches being in NFS git tree. Did they fall
> > through the cracks?
> 
> I have these patches in my tree starting with this commit:
> http://git.linux-nfs.org/?p=anna/linux-nfs.git;a=commit;h=37d4159dd25ade59ce0fecc75984240e5f7abc14

Aha, great! I was checking the tree mentioned in MAINTAINERS file which is
Trond's one and because it seemed fairly active it didn't occur to me you
are maintaining your tree as well. Thanks for the link!

One more question: Do you plan to push these changes for 6.11 or 6.12?

								Honza

Anna Schumaker July 18, 2024, 7:26 p.m. UTC | #4

On Thu, Jul 18, 2024 at 5:47 AM Jan Kara <[e-mail]> wrote:
>
> Hi Anna!
>
> On Wed 17-07-24 13:44:57, Anna Schumaker wrote:
> > On Wed, Jul 17, 2024 at 11:58 AM Jan Kara <[e-mail]> wrote:
> > >
> > > Ping? I don't see these patches being in NFS git tree. Did they fall
> > > through the cracks?
> >
> > I have these patches in my tree starting with this commit:
> > http://git.linux-nfs.org/?p=anna/linux-nfs.git;a=commit;h=37d4159dd25ade59ce0fecc75984240e5f7abc14
>
> Aha, great! I was checking the tree mentioned in MAINTAINERS file which is
> Trond's one and because it seemed fairly active it didn't occur to me you
> are maintaining your tree as well. Thanks for the link!

And this is the first time I've thought about adding my tree to the
MAINTAINERS file. I should probably do that to avoid confusion in the
future!

>
> One more question: Do you plan to push these changes for 6.11 or 6.12?

They'll be in my pull request for 6.11 that I hope to have out in the
next hour or so.

Anna

>
>                                                                 Honza
> --
> Jan Kara <[e-mail]>
> SUSE Labs, CR