| Message ID | 20241021142343.3857891-1-yangerkun@huaweicloud.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | bugfix for c_show/e_show | expand |
On Mon, 2024-10-21 at 22:23 +0800, Yang Erkun wrote: > Yang Erkun (3): > nfsd: make sure exp active before svc_export_show > SUNRPC: make sure cache entry active before cache_show > nfsd: release svc_expkey/svc_export with rcu_work > > fs/nfsd/export.c | 36 +++++++++++++++++++++++++++++------- > fs/nfsd/export.h | 4 ++-- > net/sunrpc/cache.c | 4 +++- > 3 files changed, 34 insertions(+), 10 deletions(-) > TIL about rcu_work! That seems like a nice clean solution for #3. All 3 patches look fine to me. You can add: Reviewed-by: Jeff Layton <jlayton@kernel.org> One thing though. We had very little RCU in nfsd in 2012, so these problems likely got introduced much later than 2.6.12. cache_get_rcu() got added in 2018, for instance. We may want a more reasonable Fixes: tag.
> On Oct 21, 2024, at 10:42 AM, Jeff Layton <jlayton@kernel.org> wrote: > > One thing though. We had very little RCU in nfsd in 2012, so these > problems likely got introduced much later than 2.6.12. cache_get_rcu() > got added in 2018, for instance. We may want a more reasonable Fixes: > tag. In cases where we don't have a specific commit ID, you can use Cc: stable@vger.kernel.org <mailto:stable@vger.kernel.org> without a Fixes: tag. But, I agree with Jeff; let's do a little research first to see if we can identify a culprit commit, just for due diligence. -- Chuck Lever
On Mon, 21 Oct 2024 22:23:40 +0800, Yang Erkun wrote: > Yang Erkun (3): > nfsd: make sure exp active before svc_export_show > SUNRPC: make sure cache entry active before cache_show > nfsd: release svc_expkey/svc_export with rcu_work > > fs/nfsd/export.c | 36 +++++++++++++++++++++++++++++------- > fs/nfsd/export.h | 4 ++-- > net/sunrpc/cache.c | 4 +++- > 3 files changed, 34 insertions(+), 10 deletions(-) > > [...] Applied to nfsd-next for v6.13, thanks! [1/3] nfsd: make sure exp active before svc_export_show commit: 41bda61ef8e915a6c93eab7bee8d2b4ee11a618e [2/3] SUNRPC: make sure cache entry active before cache_show commit: 1ec5e108acbfbb79e9f2ab3b516d5a29ffb554ae [3/3] nfsd: release svc_expkey/svc_export with rcu_work commit: 9998b0dcb4f2dbba2f084376a58c7261b6d5a541 -- Chuck Lever <chuck.lever@oracle.com>