[0/2] VFS: minor improvements to a couple of interfaces

Message

NeilBrown Feb. 7, 2025, 3:36 a.m. UTC

Hi,
 I found these opportunities for simplification as part of my work to
 enhance filesystem directory operations to not require an exclusive
 lock on the directory.
 There are quite a collection of users of these interfaces incluing NFS,
 smb/server, bcachefs, devtmpfs, and audit.  Hence the long Cc line.

NeilBrown

 [PATCH 1/2] VFS: change kern_path_locked() and user_path_locked_at()
 [PATCH 2/2] VFS: add common error checks to lookup_one_qstr_excl()

Comments

Christian Brauner Feb. 10, 2025, 8:25 a.m. UTC | #1

On Fri, 07 Feb 2025 14:36:46 +1100, NeilBrown wrote:
>  I found these opportunities for simplification as part of my work to
>  enhance filesystem directory operations to not require an exclusive
>  lock on the directory.
>  There are quite a collection of users of these interfaces incluing NFS,
>  smb/server, bcachefs, devtmpfs, and audit.  Hence the long Cc line.
> 
> NeilBrown
> 
> [...]

I've taken your first cleanup. Thanks for splitting those out of the
other series.

---

Applied to the vfs-6.15.misc branch of the vfs/vfs.git tree.
Patches in the vfs-6.15.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.15.misc

[1/2] VFS: change kern_path_locked() and user_path_locked_at() to never return negative dentry
      https://git.kernel.org/vfs/vfs/c/2ebf0c6b48d8
[2/2] VFS: add common error checks to lookup_one_qstr_excl()
      https://git.kernel.org/vfs/vfs/c/4b3c043c69bc

Al Viro Feb. 10, 2025, 8:42 a.m. UTC | #2

On Mon, Feb 10, 2025 at 09:25:26AM +0100, Christian Brauner wrote:
> On Fri, 07 Feb 2025 14:36:46 +1100, NeilBrown wrote:
> >  I found these opportunities for simplification as part of my work to
> >  enhance filesystem directory operations to not require an exclusive
> >  lock on the directory.
> >  There are quite a collection of users of these interfaces incluing NFS,
> >  smb/server, bcachefs, devtmpfs, and audit.  Hence the long Cc line.
> > 
> > NeilBrown
> > 
> > [...]
> 
> I've taken your first cleanup. Thanks for splitting those out of the
> other series.
> 
> ---
> 
> Applied to the vfs-6.15.misc branch of the vfs/vfs.git tree.
> Patches in the vfs-6.15.misc branch should appear in linux-next soon.

Might be better to put it into a separate branch, so that further
work in that direction wouldn't be mixed with other stuff...

Christian Brauner Feb. 10, 2025, 9:41 a.m. UTC | #3

On Mon, Feb 10, 2025 at 08:42:46AM +0000, Al Viro wrote:
> On Mon, Feb 10, 2025 at 09:25:26AM +0100, Christian Brauner wrote:
> > On Fri, 07 Feb 2025 14:36:46 +1100, NeilBrown wrote:
> > >  I found these opportunities for simplification as part of my work to
> > >  enhance filesystem directory operations to not require an exclusive
> > >  lock on the directory.
> > >  There are quite a collection of users of these interfaces incluing NFS,
> > >  smb/server, bcachefs, devtmpfs, and audit.  Hence the long Cc line.
> > > 
> > > NeilBrown
> > > 
> > > [...]
> > 
> > I've taken your first cleanup. Thanks for splitting those out of the
> > other series.
> > 
> > ---
> > 
> > Applied to the vfs-6.15.misc branch of the vfs/vfs.git tree.
> > Patches in the vfs-6.15.misc branch should appear in linux-next soon.
> 
> Might be better to put it into a separate branch, so that further
> work in that direction wouldn't be mixed with other stuff...

Yep, good call:

vfs-6.15.async.dir