mbox series

[v2,0/7] nfsd: filecache: various fixes

Message ID 20250218153937.6125-1-cel@kernel.org (mailing list archive)
Headers show
Series nfsd: filecache: various fixes | expand

Message

Chuck Lever Feb. 18, 2025, 3:39 p.m. UTC
From: Chuck Lever <chuck.lever@oracle.com>

Redriving to continue review dialogue:

> following is my attempt to fix up shrinking and gc of the NFSv3 filecache entries.
> There series is against nfsd-next.

https://lore.kernel.org/linux-nfs/20250207051701.3467505-1-neilb@suse.de/


Changes since original posting:
- I've assumed the role of shepherd for this series
- Rebase on the public nfsd-testing branch
- Remove nfsd_file_laundrette() call from nfsd_file_put() earlier in
  the series
- Rework nfsd_file_gc_worker()
- Clarify one or two commit messages

Chuck Lever (1):
  NFSD: Re-organize nfsd_file_gc_worker()

NeilBrown (6):
  nfsd: filecache: remove race handling.
  nfsd: filecache: use nfsd_file_dispose_list() in
    nfsd_file_close_inode_sync()
  nfsd: filecache: use list_lru_walk_node() in nfsd_file_gc()
  nfsd: filecache: introduce NFSD_FILE_RECENT
  nfsd: filecache: don't repeatedly add/remove files on the lru list
  nfsd: filecache: drop the list_lru lock during lock gc scans

 fs/nfsd/filecache.c | 122 ++++++++++++++++++++++++--------------------
 fs/nfsd/filecache.h |   7 +++
 fs/nfsd/trace.h     |   3 ++
 3 files changed, 77 insertions(+), 55 deletions(-)

Comments

Chuck Lever Feb. 20, 2025, 6:22 p.m. UTC | #1
On 2/18/25 10:39 AM, cel@kernel.org wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
> 
> Redriving to continue review dialogue:
> 
>> following is my attempt to fix up shrinking and gc of the NFSv3 filecache entries.
>> There series is against nfsd-next.
> 
> https://lore.kernel.org/linux-nfs/20250207051701.3467505-1-neilb@suse.de/

I've pulled this series (with suggested updates) into nfsd-testing to
gain a little more test exposure.


> Changes since original posting:
> - I've assumed the role of shepherd for this series
> - Rebase on the public nfsd-testing branch
> - Remove nfsd_file_laundrette() call from nfsd_file_put() earlier in
>   the series
> - Rework nfsd_file_gc_worker()
> - Clarify one or two commit messages
> 
> Chuck Lever (1):
>   NFSD: Re-organize nfsd_file_gc_worker()
> 
> NeilBrown (6):
>   nfsd: filecache: remove race handling.
>   nfsd: filecache: use nfsd_file_dispose_list() in
>     nfsd_file_close_inode_sync()
>   nfsd: filecache: use list_lru_walk_node() in nfsd_file_gc()
>   nfsd: filecache: introduce NFSD_FILE_RECENT
>   nfsd: filecache: don't repeatedly add/remove files on the lru list
>   nfsd: filecache: drop the list_lru lock during lock gc scans
> 
>  fs/nfsd/filecache.c | 122 ++++++++++++++++++++++++--------------------
>  fs/nfsd/filecache.h |   7 +++
>  fs/nfsd/trace.h     |   3 ++
>  3 files changed, 77 insertions(+), 55 deletions(-)
>