From patchwork Mon Sep 18 18:49:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dai Ngo X-Patchwork-Id: 13390254 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BBB6C46CA1 for ; Mon, 18 Sep 2023 18:50:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229823AbjIRSuI (ORCPT ); Mon, 18 Sep 2023 14:50:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229750AbjIRSuH (ORCPT ); Mon, 18 Sep 2023 14:50:07 -0400 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1908F7 for ; Mon, 18 Sep 2023 11:50:01 -0700 (PDT) Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38II0ArO022054; Mon, 18 Sep 2023 18:49:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : references : to : cc : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=lukqR4XXYGh4WFdFTmD4dAoDo8XXDKnnZZqxqvXyQ6s=; b=Y+11K/4csdlKeqgpUCKWuGJAI1eNl3nQ7Ssbdy3pgfirLM2DsSQ0/0ts5R6KrHTWZvMe 7ItNCBVg8umvKO3HrX+mTUvnL9SX6wqcr8/XFKuPRn8AzG8xmSn+T8Ml4bRvGMKxBsJ1 6w2J+ZlxbmzCSskroaLhtesFt9k5ZhyB7KE6tm1+C6xMG3on6CVE6Qsm7TiOSsFwxKNO esugBqP1t7dWUh6raeWBYvsKQaE9wZMPSaY46TjJgiRMc/fhx1nYqRbWBrOmPo61zI0p TsZaV7WqwrycH9sf8Px4Go3fPge2Tmh8riSXHs/EsPy/Tyyd/EMQQtY7i8G1wM2ICVqI bg== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3t54dd38k6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 Sep 2023 18:49:56 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 38II6RCe002153; Mon, 18 Sep 2023 18:49:55 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2168.outbound.protection.outlook.com [104.47.73.168]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3t52t4e2cs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 Sep 2023 18:49:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VvlXYJSik4AmqYkYMIMgj2mXdM56bcHxSl41bbdKqdqxd6v57dGr+Sa4X8z1jXDdK5FDEhaJC1nLsHq6NY6NN/Is1rhJThSURz/V47dlIaP7KEz2Hxu3Yk+340VZiHq97Bg+eZf9v3BWg4vrwWlfkRtT+K0p1o/h6Uw6E/EKD8M+Fznk+jklFqAT58TAFgzBTmvp9c+YnIgp9ZjIB07gXl0tyogH9h6kUZNWpRfBpbTB3sD7WCL3+cL95hDvB/7+E3+ZzDxq4bVOpn/OTq5ZXHBXp5PWcUDpYcZ75t3qkzaKSPolifJQC9xQ2ILMlzD0sSfWfcatP6S9iyhfsYETAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lukqR4XXYGh4WFdFTmD4dAoDo8XXDKnnZZqxqvXyQ6s=; b=QE3ltPT8vFNryl444Qb/qUTgKzTYQPwkE+O/aBFz7VjuiW9MkTn/tjeqnv4dEwg8UTCz8Zf9LeI/L0LvQfdQ9gSRYvn6VNuRmrVWQDIZ0TJSjN8o8pa6dSDYjo6uWTxfxjFgKUa7iiMy05QjjvdweFx8ptSe81LIzhPsClnHvpbDXLEMvnwO7n/gGZrUIY6Adu+No2/O8ZMzVrXTB2xRyvQlilYWAg/cT5c/X4+5YtdxKNZ4mrz3E0ShKbjQo6yOaOjRBn8HXYBayw2BtjxISyNEULDVUq8zU0g6HAwe3blRg5zqlDfC/XoEbwu1aXjfsHrQGRtxEpwqGoIrsFIB6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lukqR4XXYGh4WFdFTmD4dAoDo8XXDKnnZZqxqvXyQ6s=; b=oOK/C4eCPN/vzMrTlAYF8e+zta4Ci9LmTtTWZ8g2W8KaT4wkZ8NXcqfIv2jq94aNWj+0BHyYh/PpOdUctYmpyzQ51V+PoIfGM0/HMXJ/r2MxFMNO5tWl/kCZtjBwSrtZLDKqQWs+r+dskRIhQvmhekdpLmz9o04ASWBk6AwViIU= Received: from BY5PR10MB4257.namprd10.prod.outlook.com (2603:10b6:a03:211::21) by MN2PR10MB4254.namprd10.prod.outlook.com (2603:10b6:208:199::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.24; Mon, 18 Sep 2023 18:49:52 +0000 Received: from BY5PR10MB4257.namprd10.prod.outlook.com ([fe80::fe75:575d:5963:93d7]) by BY5PR10MB4257.namprd10.prod.outlook.com ([fe80::fe75:575d:5963:93d7%5]) with mapi id 15.20.6792.026; Mon, 18 Sep 2023 18:49:52 +0000 Message-ID: <036ba970-a302-097a-1155-881f4ec3f8b8@oracle.com> Date: Mon, 18 Sep 2023 11:49:48 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Fwd: [PATCH v3 1/1] nfs42: client needs to strip file mode's suid/sgid bit after ALLOCATE op References: <1692918707-30648-1-git-send-email-dai.ngo@oracle.com> Content-Language: en-US To: Anna Schumaker Cc: Trond Myklebust , "linux-nfs@vger.kernel.org" From: dai.ngo@oracle.com In-Reply-To: <1692918707-30648-1-git-send-email-dai.ngo@oracle.com> X-Forwarded-Message-Id: <1692918707-30648-1-git-send-email-dai.ngo@oracle.com> X-ClientProxiedBy: BYAPR11CA0090.namprd11.prod.outlook.com (2603:10b6:a03:f4::31) To BY5PR10MB4257.namprd10.prod.outlook.com (2603:10b6:a03:211::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR10MB4257:EE_|MN2PR10MB4254:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c160fad-d29d-4de3-5f07-08dbb8780aff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JSiwbJ71WAWi27M7vyfmGP9XTesLI2gbQrjk681V8ot5Yw5+ylLKeVv1xQDB1chQtvnP0UnpLY6iq2in+QGkZj+Hqsh2HCnvK/k6rYSvhpEcOsig0XJc3KdAwY91LYip/S2Ery0GqJiUv2u+/Nq37Pu0GbtYbbZgmqBDL9Gvbs67iMqvcnXIvFSMWzxg0zuMyTSbzMmdrv5y0iONyRwn2os92fy0S8MTRZVZp9D7pQr2WwX6p7jDbd6uNU/4DLM47qVpaxANbQvyliL0mV2xVRsr3Gk1BnDPEg6hyrAUMCGDskvTfzifcigTbLQ1KG4EayWspL6N4Spt7st2kFWkIHekj+iWeZSMCagI15JsQ83JR98SZdplqnoY/wU7Il1P7KACDXwzDbMbFwtZqfmaXVWmjnVtiWurnYfsRqhQS1lrswEMlyto1K1iziOdibvFKh396zR+8J7wu0JP7MW9TCVExM2lxuoCmlxJ3eDOFcFTxxRSHWMi2dOOuLuMZ1I4dkWRIejP8WDR4PeRXPn/VfAbH5r1p3r1+hTnhCsXhuWiEzrt+lBooPosxrzV/9Ik9gezCuhtNv96v8BMH6EeM+Wxgetc589ek9lmhRG7ib8z3lQ0jOc0Jy7zJnIU5Jbl X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4257.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(366004)(346002)(376002)(39860400002)(396003)(186009)(1800799009)(451199024)(26005)(8936002)(2616005)(8676002)(4326008)(83380400001)(2906002)(36756003)(31696002)(5660300002)(86362001)(6506007)(6486002)(478600001)(6666004)(31686004)(6916009)(316002)(54906003)(9686003)(6512007)(66946007)(66476007)(66556008)(38100700002)(41300700001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?H+XtQ3/t0z/5bybVdWPTkmsvYsYo?= =?utf-8?q?xduwXn/ViLX8L/FpSTWocZLX9uKJR2lfLY8TSx8RrFVv08tdnxfdzdFIxKGewTOQz?= =?utf-8?q?HoG+3p7FYOSqVoBqL03W+UUsSRnTIWb4wq7AJ4FfqhdMjxYntVYdNxdY9V2FX7b5I?= =?utf-8?q?XeFihAYxFdb/f+27bmo7Kmwv4whQEKYOrCYqWzsHPm/GWm4A2duR6SArrP3m2UjzD?= =?utf-8?q?/AHCA/9HdsrZ1DZGHZYKstrDKClgtBQBNPK62Hq7fuE7Gg/v4iFrYJLG+91fwuI+7?= =?utf-8?q?TGza0W0YDt0hFa9gyvtlICcKYRPPGpTjpBWdmBDRpFOyU8AcrVjgYvNLLZL9yq6zD?= =?utf-8?q?aQl2hxs8AtmJw52bWdPdLHqy6PbI9FyQwmdRtuDvcPH41IzLjiqgtsYQHhtja7WbL?= =?utf-8?q?e/R8dlUzWicOa311BTIzIOO4LNuBAKLbhJdTK/ugoGdGWzIYMMCIjpiJqu/d04bpE?= =?utf-8?q?PrOhl7QbNA5Aa1rRNvVXaz4WyaW54nchgdW3LgKho5t6O1qtkEHE2GCf4B57CqOk1?= =?utf-8?q?DB/XA1Tdm6kSQTBQObNVNXpZ/RLwsfwdEY/sBXtXo+PJnhPFToXqYWQJUyIkNp4pS?= =?utf-8?q?f5aIgdXKYeRY+r5o2DQRzZ8odi5KHr8WvJvKkBDVPV9xL77dS18C8GUm6IO3vrlRP?= =?utf-8?q?RUheXd8q0JOcUctdcEtx1t3UHh4tU/p+pxQ9aVIGX/V6C/LEdKRemmuMZatQeRG4w?= =?utf-8?q?wBFF1JKU5Ny4Wcp/+vN5lb/337LqilaCL5KPmxLtGIMZSAXoQ/tQ9cPIzvhVuiRGU?= =?utf-8?q?zaPXYruIlOxUg9JDuNDCMlr1Or5y/OdfI7kdvqkzTcSjw1TIm2mPTGzZqwsNDzkTo?= =?utf-8?q?5c+mu7mY9ZcDYQf88Ao06qwgCWsmBw91SET8XN9TotGitoLYdulo09hyLSgPYdJuI?= =?utf-8?q?Cklwm4sctEznjopNv9XSBFhs01N5xP0dOR0WDe5mRhXDqKFq5nVP2Hx6n48uI+bCM?= =?utf-8?q?yTrz1Ux+Uq89tI4+TnsM30vI+DEFVcmkcs79tMgf37zKmabVNOU+80/t13PbJ+lA2?= =?utf-8?q?hr4D3g79PkSiE1DKrHh0hMsPAe7n5cDf4QkimTyRCj/mcXMnPOyqV4udFeC9iSEEs?= =?utf-8?q?xXE9IvaFkIQZShbxOsL6HeoIxqDFXjT6oVDn7qlUd24+4t8rjsYXFVbPf9yE5RvVK?= =?utf-8?q?3K5R7TT8Q1IZiNoUcHT47t8wI23v5qXD6tzkt5TtW9E9YWiszKrm9S1cUcjxqsloq?= =?utf-8?q?I/KNhKdL273Pt+d9YF5oi8FmcVjST6wM0ORaLu8FK/G4Rj29fcSoIS64LzUbWoXIO?= =?utf-8?q?eZz3tktlwu4kfkH/wfy+6sROE20SfWf4rEmINAj0ll7t5SBQ7ib4Xk0ZLog9vzy8y?= =?utf-8?q?SWSrlhyUROcVdXhr297wmFS8xwj0k209BU5CQ1L02OaOlzLGD5IhOFgqbQIuHr3Mg?= =?utf-8?q?o86hpO7XYXIDAijEuWJkPStCDoxgSN0GPaXyiL+nAFkxQXgXathmIeRmAHtMawWPh?= =?utf-8?q?jdLG/YYdqWDu2G7U9cKczqMG1Z2xLqhNz2s5TLsuZHUKQ3W06/c0noiZwYAhw2ZRJ?= =?utf-8?q?gErIafhKwTe6?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: g1KUH0aPwN7Is3RCMXTOZFScju982jgm76xbxUUmRAu9ziD159cw4/4ttIZFfUlOoSWIOjCKLZFHS91bHpZKB2M6Q0lEpJDdcFDbTQHa79LOMeVEHqB+QbeeznlpdanmzCtCzrkP/h+RUr60/xNRv0LWHGgB0AxGDlEOiPy0G2vKxBz7Ift6h6CX42uJ4BMCe+dxThbZFv4aEh/Rs4klQxagfP+ndMcjiGxyG1wM4pIGwjk6LO5yDMHNvILqOPguKcIBM2Q0v8mrCz/pTNcdZ7bzO6mV2XTuMHu1YCoQ4WYGWn3MqXBquU06rWeezOcCTzeerP3hkD7P3FzE2T/O4Ppven/oLfWRNu4wYnyVUCdJKVZfGknQGXQnJMc5FDNFQcQN/Ov20JIveONC5khVseHpb3EYVP9eNapwx9orJYiXNsVremwVJX5A1U1fF6gZarzraNTpN9BuKul3tViE8wBp0MbQNG3GRMS5ZAcocyWS3yOQFucThPgZAH+xcdeZYNcOC4iCi1WEpoqhTBfz+GcRTEHbRvjMVr34Ecy3aHyBf9jrJJiMC4jqxDdDm3qEoKLgxkkjTv2m0lNnTaC/5bV2xMRDf/5GVMq3jIpbPim6YiSUJb1w8IxpLSzX+MMsOxo+enUEWmPAvyMq9+zGLwCJzeEcfCd+m+eOD49mmZcnZlJ5KKzTK/rk+eItOVotRUK47fnvFAP+TQFalyS1qxRhJ+BnQ6RAiMznScofHu725WWO4YdkjBRPk/MC56H4vUoccf92+AqrVf1TLAUNWWSzz4UXC3MNEJjdoZHORBxhFIaLWTqqfdUEQN6RVAVeQuF9GIJzncrPOys/SaEUig== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c160fad-d29d-4de3-5f07-08dbb8780aff X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4257.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2023 18:49:52.6823 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mKBhCkxh1g7ZLW+8Kk8yo2aPYDLFmnVQ1pRZ/X/Ja5FFTkavRWTGjgjNO3tmROWytj7/VZPRCk9vgl9NtxJTbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4254 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-18_08,2023-09-18_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 phishscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309180165 X-Proofpoint-GUID: rgFpMMa6mGMtg2rUTNPZgPQg01avKp81 X-Proofpoint-ORIG-GUID: rgFpMMa6mGMtg2rUTNPZgPQg01avKp81 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Hi Anna, Was this patch rejected? The fix was suggested by Trond. I should have the 'Suggested-by: Trond Myklebust' tag. Thanks, -Dai -------- Forwarded Message -------- Subject: [PATCH v3 1/1] nfs42: client needs to strip file mode's suid/sgid bit after ALLOCATE op Date: Thu, 24 Aug 2023 16:11:47 -0700 From: Dai Ngo To: trondmy@hammerspace.com, anna@kernel.org CC: linux-nfs@vger.kernel.org The Linux NFS server strips the SUID and SGID from the file mode on ALLOCATE op. Modify _nfs42_proc_fallocate to add NFS_INO_REVAL_FORCED to nfs_set_cache_invalid's argument to force update of the file mode suid/sgid bit. Signed-off-by: Dai Ngo --- fs/nfs/nfs42proc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) status = nfs_post_op_update_inode_force_wcc(inode, diff --git a/fs/nfs/nfs42proc.c b/fs/nfs/nfs42proc.c index 63802d195556..9d2f07feeb29 100644 --- a/fs/nfs/nfs42proc.c +++ b/fs/nfs/nfs42proc.c @@ -81,7 +81,8 @@ static int _nfs42_proc_fallocate(struct rpc_message *msg, struct file *filep, if (status == 0) { if (nfs_should_remove_suid(inode)) { spin_lock(&inode->i_lock); - nfs_set_cache_invalid(inode, NFS_INO_INVALID_MODE); + nfs_set_cache_invalid(inode, + NFS_INO_REVAL_FORCED | NFS_INO_INVALID_MODE); spin_unlock(&inode->i_lock); }