From patchwork Wed Feb 23 13:51:50 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Aneesh Kumar K.V" X-Patchwork-Id: 584371 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p1NDrUAf024265 for ; Wed, 23 Feb 2011 13:53:31 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755414Ab1BWNxC (ORCPT ); Wed, 23 Feb 2011 08:53:02 -0500 Received: from e28smtp01.in.ibm.com ([122.248.162.1]:60248 "EHLO e28smtp01.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755399Ab1BWNxA (ORCPT ); Wed, 23 Feb 2011 08:53:00 -0500 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by e28smtp01.in.ibm.com (8.14.4/8.13.1) with ESMTP id p1NDqwG2020750; Wed, 23 Feb 2011 19:22:58 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p1NDquTb590036; Wed, 23 Feb 2011 19:22:57 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p1NDqrrZ016719; Thu, 24 Feb 2011 00:52:56 +1100 Received: from skywalker.ibm.com ([9.77.68.27]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p1NDqS1u014791; Thu, 24 Feb 2011 00:52:49 +1100 From: "Aneesh Kumar K.V" To: sfrench@us.ibm.com, agruen@linbit.com, dilger.kernel@dilger.ca, sandeen@redhat.com, tytso@mit.edu, bfields@fieldses.org, jlayton@redhat.com Cc: aneesh.kumar@linux.vnet.ibm.com, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Andreas Gruenbacher Subject: [PATCH -V5 03/24] vfs: Add a comment to inode_permission() Date: Wed, 23 Feb 2011 19:21:50 +0530 Message-Id: <1298469131-16555-4-git-send-email-aneesh.kumar@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1298469131-16555-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> References: <1298469131-16555-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Wed, 23 Feb 2011 13:53:31 +0000 (UTC) diff --git a/fs/namei.c b/fs/namei.c index f09ab1f..0bfc546 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -167,7 +167,7 @@ EXPORT_SYMBOL(putname); #endif /* - * This does basic POSIX ACL permission checking + * This does the basic permission checking */ static int acl_permission_check(struct inode *inode, int mask, unsigned int flags, int (*check_acl)(struct inode *inode, int mask, unsigned int flags)) @@ -217,7 +217,7 @@ int generic_permission(struct inode *inode, int mask, unsigned int flags, int ret; /* - * Do the basic POSIX ACL permission checks. + * Do the basic permission checks. */ ret = acl_permission_check(inode, mask, flags, check_acl); if (ret != -EACCES) @@ -251,6 +251,8 @@ int generic_permission(struct inode *inode, int mask, unsigned int flags, * We use "fsuid" for this, letting us set arbitrary permissions * for filesystem access without changing the "normal" uids which * are used for other things. + * + * When checking for MAY_APPEND, MAY_WRITE must also be set in @mask. */ int inode_permission(struct inode *inode, int mask) {