diff mbox

[RFC,11/27] pnfs: per mount layout driver private data

Message ID 1303320461-21369-1-git-send-email-bhalevy@panasas.com (mailing list archive)
State New, archived
Headers show

Commit Message

Benny Halevy April 20, 2011, 5:27 p.m. UTC 
Signed-off-by: Benny Halevy <bhalevy@panasas.com>
---
 include/linux/nfs_fs_sb.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Comments

Trond Myklebust April 20, 2011, 8:36 p.m. UTC | #1 
On Wed, 2011-04-20 at 20:27 +0300, Benny Halevy wrote:
> Signed-off-by: Benny Halevy <bhalevy@panasas.com>
> ---
>  include/linux/nfs_fs_sb.h |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/nfs_fs_sb.h b/include/linux/nfs_fs_sb.h
> index 216cea5..c5b3fd0 100644
> --- a/include/linux/nfs_fs_sb.h
> +++ b/include/linux/nfs_fs_sb.h
> @@ -142,6 +142,9 @@ struct nfs_server {
>  						   filesystem */
>  	struct pnfs_layoutdriver_type  *pnfs_curr_ld; /* Active layout driver */
>  	struct rpc_wait_queue	roc_rpcwaitq;
> +	void			       *pnfs_ld_data; /* Per-mount data */
> +	unsigned int			ds_rsize;  /* Data server read size */
> +	unsigned int			ds_wsize;  /* Data server write size */

Shouldn't the rsize and wsize be part of the layout driver private data?

>  
>  	/* the following fields are protected by nfs_client->cl_lock */
>  	struct rb_root		state_owners;
Benny Halevy April 22, 2011, 9:05 a.m. UTC | #2 
On 2011-04-20 23:36, Trond Myklebust wrote:
> On Wed, 2011-04-20 at 20:27 +0300, Benny Halevy wrote:
>> Signed-off-by: Benny Halevy <bhalevy@panasas.com>
>> ---
>>  include/linux/nfs_fs_sb.h |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/linux/nfs_fs_sb.h b/include/linux/nfs_fs_sb.h
>> index 216cea5..c5b3fd0 100644
>> --- a/include/linux/nfs_fs_sb.h
>> +++ b/include/linux/nfs_fs_sb.h
>> @@ -142,6 +142,9 @@ struct nfs_server {
>>  						   filesystem */
>>  	struct pnfs_layoutdriver_type  *pnfs_curr_ld; /* Active layout driver */
>>  	struct rpc_wait_queue	roc_rpcwaitq;
>> +	void			       *pnfs_ld_data; /* Per-mount data */
>> +	unsigned int			ds_rsize;  /* Data server read size */
>> +	unsigned int			ds_wsize;  /* Data server write size */
> 
> Shouldn't the rsize and wsize be part of the layout driver private data?
> 

Oops, they're not used anymore (they were previously
used by the files layout). I'll just get rid of them.

Benny

>>  
>>  	/* the following fields are protected by nfs_client->cl_lock */
>>  	struct rb_root		state_owners;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/linux/nfs_fs_sb.h b/include/linux/nfs_fs_sb.h
index 216cea5..c5b3fd0 100644
--- a/include/linux/nfs_fs_sb.h
+++ b/include/linux/nfs_fs_sb.h
@@ -142,6 +142,9 @@  struct nfs_server {
 						   filesystem */
 	struct pnfs_layoutdriver_type  *pnfs_curr_ld; /* Active layout driver */
 	struct rpc_wait_queue	roc_rpcwaitq;
+	void			       *pnfs_ld_data; /* Per-mount data */
+	unsigned int			ds_rsize;  /* Data server read size */
+	unsigned int			ds_wsize;  /* Data server write size */
 
 	/* the following fields are protected by nfs_client->cl_lock */
 	struct rb_root		state_owners;