diff mbox

[1/1] nfsd v4.1 lOCKT clientid field must be ignored

Message ID 1303490759-2646-2-git-send-email-andros@netapp.com (mailing list archive)
State New, archived
Headers show

Commit Message

Andy Adamson April 22, 2011, 4:45 p.m. UTC 
From: Andy Adamson <andros@netapp.com>

RFC 5661 Section 18.11.3

   The clientid field of the owner MAY be set to any value by the client
   and MUST be ignored by the server.  The reason the server MUST ignore
   the clientid field is that the server MUST derive the client ID from
   the session ID from the SEQUENCE operation of the COMPOUND request.

Signed-off-by: Andy Adamson <andros@netapp.com>
---
 fs/nfsd/nfs4xdr.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

Comments

Bruce Fields April 22, 2011, 4:54 p.m. UTC | #1 
On Fri, Apr 22, 2011 at 12:45:59PM -0400, andros@netapp.com wrote:
> From: Andy Adamson <andros@netapp.com>
> 
> RFC 5661 Section 18.11.3
> 
>    The clientid field of the owner MAY be set to any value by the client
>    and MUST be ignored by the server.  The reason the server MUST ignore
>    the clientid field is that the server MUST derive the client ID from
>    the session ID from the SEQUENCE operation of the COMPOUND request.

I thought I'd checked the network and determined the failure prevented
the client from even sending a request--but I guess not!  Thanks for
tracking this down, applied.--b.

> 
> Signed-off-by: Andy Adamson <andros@netapp.com>
> ---
>  fs/nfsd/nfs4xdr.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index abdd42d..eb234df 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -591,8 +591,6 @@ nfsd4_decode_lockt(struct nfsd4_compoundargs *argp, struct nfsd4_lockt *lockt)
>  	READ_BUF(lockt->lt_owner.len);
>  	READMEM(lockt->lt_owner.data, lockt->lt_owner.len);
>  
> -	if (argp->minorversion && !zero_clientid(&lockt->lt_clientid))
> -		return nfserr_inval;
>  	DECODE_TAIL;
>  }
>  
> -- 
> 1.7.2.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index abdd42d..eb234df 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -591,8 +591,6 @@  nfsd4_decode_lockt(struct nfsd4_compoundargs *argp, struct nfsd4_lockt *lockt)
 	READ_BUF(lockt->lt_owner.len);
 	READMEM(lockt->lt_owner.data, lockt->lt_owner.len);
 
-	if (argp->minorversion && !zero_clientid(&lockt->lt_clientid))
-		return nfserr_inval;
 	DECODE_TAIL;
 }