From patchwork Tue May 24 15:05:21 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Boaz Harrosh X-Patchwork-Id: 812482 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p4OF5tsu022572 for ; Tue, 24 May 2011 15:05:55 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754482Ab1EXPFy (ORCPT ); Tue, 24 May 2011 11:05:54 -0400 Received: from daytona.panasas.com ([67.152.220.89]:46655 "EHLO daytona.panasas.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754481Ab1EXPFw (ORCPT ); Tue, 24 May 2011 11:05:52 -0400 Received: from fs2.bhalevy.com ([172.17.33.70]) by daytona.panasas.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 24 May 2011 11:05:51 -0400 From: Boaz Harrosh To: Benny Halevy , Trond Myklebust , NFS list Subject: [PATCH 03/12] SQUSHME: pnfs: BUG in _deviceid_purge_client Date: Tue, 24 May 2011 18:05:21 +0300 Message-Id: <1306249521-23244-1-git-send-email-bharrosh@panasas.com> X-Mailer: git-send-email 1.7.2.3 In-Reply-To: <4DDBC611.3050202@panasas.com> References: <4DDBC611.3050202@panasas.com> X-OriginalArrivalTime: 24 May 2011 15:05:51.0813 (UTC) FILETIME=[127B7F50:01CC1A24] Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Tue, 24 May 2011 15:05:55 +0000 (UTC) The atomic_dec_and_test() returns *true* when zero. The ! belongs to atomic_dec(). Fixit Signed-off-by: Boaz Harrosh --- fs/nfs/pnfs_dev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfs/pnfs_dev.c b/fs/nfs/pnfs_dev.c index 7e5542c..37ca215 100644 --- a/fs/nfs/pnfs_dev.c +++ b/fs/nfs/pnfs_dev.c @@ -258,7 +258,7 @@ _deviceid_purge_client(const struct nfs_client *clp, long hash) synchronize_rcu(); hlist_for_each_entry_safe(d, n, next, &tmp, node) - if (!atomic_dec_and_test(&d->ref)) { + if (atomic_dec_and_test(&d->ref)) { if (d->ld->free_deviceid_node) d->ld->free_deviceid_node(d); else