From patchwork Tue May 24 15:08:05 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Boaz Harrosh X-Patchwork-Id: 812552 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.3) with ESMTP id p4OF8cks030461 for ; Tue, 24 May 2011 15:08:38 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753222Ab1EXPIh (ORCPT ); Tue, 24 May 2011 11:08:37 -0400 Received: from daytona.panasas.com ([67.152.220.89]:46830 "EHLO daytona.panasas.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752695Ab1EXPIh (ORCPT ); Tue, 24 May 2011 11:08:37 -0400 Received: from fs2.bhalevy.com ([172.17.33.70]) by daytona.panasas.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 24 May 2011 11:08:36 -0400 From: Boaz Harrosh To: Benny Halevy , Trond Myklebust , NFS list Subject: [PATCH 10/12] SQUASHME: pnfs-obj: objlayout wants to cache devices until unmount Date: Tue, 24 May 2011 18:08:05 +0300 Message-Id: <1306249685-23453-1-git-send-email-bharrosh@panasas.com> X-Mailer: git-send-email 1.7.2.3 In-Reply-To: <4DDBC611.3050202@panasas.com> References: <4DDBC611.3050202@panasas.com> X-OriginalArrivalTime: 24 May 2011 15:08:36.0423 (UTC) FILETIME=[7498FD70:01CC1A24] Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Tue, 24 May 2011 15:08:38 +0000 (UTC) Take an extra reference on a device insert. So devices keep around in the cache until nfs_client release. (This was the behavior of the old cache) The extra reference will be removed in nfs4_deviceid_purge_client(). I tested this and it works perfectly. TODO: Define an nfs4_get_deviceid() Currently accesing did->ref directly TODO: nfs4_insert_deviceid_node should check if there are too many devices and start purging them. Say by time from last use. Signed-off-by: Boaz Harrosh --- fs/nfs/objlayout/objio_osd.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/nfs/objlayout/objio_osd.c b/fs/nfs/objlayout/objio_osd.c index faacde2..8b05b16 100644 --- a/fs/nfs/objlayout/objio_osd.c +++ b/fs/nfs/objlayout/objio_osd.c @@ -104,6 +104,7 @@ _dev_list_add(const struct nfs_server *nfss, de = n; } + atomic_inc(&de->id_node.ref); return de; }