From patchwork Wed Jun 15 19:15:35 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fred Isaman X-Patchwork-Id: 883212 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p5FJFuid011938 for ; Wed, 15 Jun 2011 19:15:56 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753575Ab1FOTPz (ORCPT ); Wed, 15 Jun 2011 15:15:55 -0400 Received: from mx2.netapp.com ([216.240.18.37]:53391 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753427Ab1FOTPz (ORCPT ); Wed, 15 Jun 2011 15:15:55 -0400 X-IronPort-AV: E=Sophos;i="4.65,371,1304319600"; d="scan'208";a="555862183" Received: from smtp1.corp.netapp.com ([10.57.156.124]) by mx2-out.netapp.com with ESMTP; 15 Jun 2011 12:15:39 -0700 Received: from localhost.localdomain (vpn2ntap-48626.hq.netapp.com [10.55.65.195]) by smtp1.corp.netapp.com (8.13.1/8.13.1/NTAP-1.6) with ESMTP id p5FJFbxm025088; Wed, 15 Jun 2011 12:15:38 -0700 (PDT) From: Fred Isaman To: linux-nfs@vger.kernel.org Cc: Trond Myklebust , Fred Isaman Subject: [PATCH 1/1] nfs4.1: check for whole file layouts is comparing against uninitialized values Date: Wed, 15 Jun 2011 15:15:35 -0400 Message-Id: <1308165335-29609-1-git-send-email-iisaman@netapp.com> X-Mailer: git-send-email 1.7.2.1 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Wed, 15 Jun 2011 19:15:56 +0000 (UTC) Signed-off-by: Fred Isaman --- fs/nfs/nfs4filelayout.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/nfs/nfs4filelayout.c b/fs/nfs/nfs4filelayout.c index 88aa8a0..7fe8e19 100644 --- a/fs/nfs/nfs4filelayout.c +++ b/fs/nfs/nfs4filelayout.c @@ -428,8 +428,8 @@ filelayout_check_layout(struct pnfs_layout_hdr *lo, dprintk("--> %s\n", __func__); /* FIXME: remove this check when layout segment support is added */ - if (fl->generic_hdr.pls_range.offset != 0 || - fl->generic_hdr.pls_range.length != NFS4_MAX_UINT64) { + if (lgr->range.offset != 0 || + lgr->range.length != NFS4_MAX_UINT64) { dprintk("%s Only whole file layouts supported. Use MDS i/o\n", __func__); goto out;