From patchwork Thu Jul 26 11:55:10 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 1242221 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 0D777DFFBF for ; Thu, 26 Jul 2012 11:58:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752445Ab2GZLzl (ORCPT ); Thu, 26 Jul 2012 07:55:41 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:52185 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752388Ab2GZLzi (ORCPT ); Thu, 26 Jul 2012 07:55:38 -0400 Received: by mail-yx0-f174.google.com with SMTP id l2so1826946yen.19 for ; Thu, 26 Jul 2012 04:55:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=fp/gGcJORXUlKJtVVLn4hnb4NSREgOBWKYaCeVdz8lc=; b=WzsGraGPKgbNa+4fOTT2QBkpBclr1KuCD38H8bXMUCJ5xC8NADdcE3q/GcdyljUpb1 TgGU4+qcfC5knqIpmsYOwy3bXf379DEoPcDSUzTFNpDA1N9uyK79tQ/i9ohsiPWpvdeq ZL+KxgwXSodg3PThcrmj9REJ4ZHULBBOzZSqVWrKutFVuSN4XIlLff8Rl5D/SWuGn6md fQJ2gXfxNBO/YJ/+ddxs34lWIeOgXkwBnnvnPRYlIHKlhRmjonr+e7nfnlsF7g1N/Wm8 gjSJfd+LePoA3qpG5VuSjA4j5HkC3Hwl1GKaIF9ktg+JbDjC7jjKux+RCb+7PIr2eyg3 nSXg== Received: by 10.236.177.42 with SMTP id c30mr26994147yhm.37.1343303737605; Thu, 26 Jul 2012 04:55:37 -0700 (PDT) Received: from salusa.poochiereds.net (cpe-076-182-054-194.nc.res.rr.com. [76.182.54.194]) by mx.google.com with ESMTPS id l12sm4436364ank.2.2012.07.26.04.55.36 (version=SSLv3 cipher=OTHER); Thu, 26 Jul 2012 04:55:37 -0700 (PDT) From: Jeff Layton To: viro@ZenIV.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, michael.brantley@deshaw.com, hch@infradead.org, miklos@szeredi.hu, pstaubach@exagrid.com Subject: [PATCH v4 07/17] vfs: add new "reval" argument to kern_path_create Date: Thu, 26 Jul 2012 07:55:10 -0400 Message-Id: <1343303720-11199-8-git-send-email-jlayton@redhat.com> X-Mailer: git-send-email 1.7.11.2 In-Reply-To: <1343303720-11199-1-git-send-email-jlayton@redhat.com> References: <1343303720-11199-1-git-send-email-jlayton@redhat.com> X-Gm-Message-State: ALoCoQl1J4KQAaiz/mFhgaWuHr4LE/VKoktXGzBVYFIxlYm8nXgLinCH31F1wE/yDJ7PLE9HDGVI Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org ...for now, all of the callers pass in "false". Eventually, we'll set that to "true" when we retry the lookup after getting back an ESTALE on a call. While we're at it, change the is_dir arg to a bool since that's how it's used currently. Signed-off-by: Jeff Layton --- drivers/base/devtmpfs.c | 7 ++++--- fs/namei.c | 12 +++++++++--- include/linux/namei.h | 2 +- net/unix/af_unix.c | 3 ++- 4 files changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c index d91a3a0..f41e49b 100644 --- a/drivers/base/devtmpfs.c +++ b/drivers/base/devtmpfs.c @@ -148,7 +148,7 @@ static int dev_mkdir(const char *name, umode_t mode) struct path path; int err; - dentry = kern_path_create(AT_FDCWD, name, &path, 1); + dentry = kern_path_create(AT_FDCWD, name, &path, true, false); if (IS_ERR(dentry)) return PTR_ERR(dentry); @@ -195,10 +195,11 @@ static int handle_create(const char *nodename, umode_t mode, struct device *dev) struct path path; int err; - dentry = kern_path_create(AT_FDCWD, nodename, &path, 0); + dentry = kern_path_create(AT_FDCWD, nodename, &path, false, false); if (dentry == ERR_PTR(-ENOENT)) { create_path(nodename); - dentry = kern_path_create(AT_FDCWD, nodename, &path, 0); + dentry = kern_path_create(AT_FDCWD, nodename, &path, + false, false); } if (IS_ERR(dentry)) return PTR_ERR(dentry); diff --git a/fs/namei.c b/fs/namei.c index 6563077..438ed67 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -2844,11 +2844,17 @@ struct file *do_file_open_root(struct dentry *dentry, struct vfsmount *mnt, return file; } -struct dentry *kern_path_create(int dfd, const char *pathname, struct path *path, int is_dir) +struct dentry *kern_path_create(int dfd, const char *pathname, struct path *path, bool is_dir, bool reval) { struct dentry *dentry = ERR_PTR(-EEXIST); struct nameidata nd; - int error = do_path_lookup(dfd, pathname, LOOKUP_PARENT, &nd); + int error; + unsigned int lookup_flags = LOOKUP_PARENT; + + if (reval) + lookup_flags |= LOOKUP_REVAL; + + error = do_path_lookup(dfd, pathname, lookup_flags, &nd); if (error) return ERR_PTR(error); @@ -2901,7 +2907,7 @@ struct dentry *user_path_create(int dfd, const char __user *pathname, struct pat struct dentry *res; if (IS_ERR(tmp)) return ERR_CAST(tmp); - res = kern_path_create(dfd, tmp, path, is_dir); + res = kern_path_create(dfd, tmp, path, (bool)is_dir, false); putname(tmp); return res; } diff --git a/include/linux/namei.h b/include/linux/namei.h index dc2a306..d56faaa 100644 --- a/include/linux/namei.h +++ b/include/linux/namei.h @@ -65,7 +65,7 @@ extern int user_path_at(int, const char __user *, unsigned, struct path *); extern int kern_path(const char *, unsigned, struct path *); -extern struct dentry *kern_path_create(int, const char *, struct path *, int); +extern struct dentry *kern_path_create(int, const char *, struct path *, bool, bool); extern struct dentry *user_path_create(int, const char __user *, struct path *, int); extern struct dentry *kern_path_locked(const char *, struct path *); extern int vfs_path_lookup(struct dentry *, struct vfsmount *, diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 641f2e4..d94caa9 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c @@ -866,7 +866,8 @@ static int unix_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len) * Get the parent directory, calculate the hash for last * component. */ - dentry = kern_path_create(AT_FDCWD, sun_path, &path, 0); + dentry = kern_path_create(AT_FDCWD, sun_path, &path, + false, false); err = PTR_ERR(dentry); if (IS_ERR(dentry)) goto out_mknod_parent;