diff mbox

NFSD: Swap the struct nfs4_operation getter and setter

Message ID 1344974108-24531-1-git-send-email-bjschuma@netapp.com (mailing list archive)
State New, archived
Headers show

Commit Message

Bryan Schumaker Aug. 14, 2012, 7:55 p.m. UTC 
From: Bryan Schumaker <bjschuma@netapp.com>

stateid_setter should be matched to op_set_currentstateid, rather than
op_get_currentstateid.

Signed-off-by: Bryan Schumaker <bjschuma@netapp.com>
---
 fs/nfsd/nfs4proc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

J. Bruce Fields Aug. 14, 2012, 7:58 p.m. UTC | #1 
On Tue, Aug 14, 2012 at 03:55:08PM -0400, bjschuma@netapp.com wrote:
> From: Bryan Schumaker <bjschuma@netapp.com>
> 
> stateid_setter should be matched to op_set_currentstateid, rather than
> op_get_currentstateid.

Why didn't we notice that?

Oh, the two prototypes are actually identical.  Eh.  OK, applying,
thanks.

--b.

> 
> Signed-off-by: Bryan Schumaker <bjschuma@netapp.com>
> ---
>  fs/nfsd/nfs4proc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
> index c9c1c0a..f2bb0ef 100644
> --- a/fs/nfsd/nfs4proc.c
> +++ b/fs/nfsd/nfs4proc.c
> @@ -1054,8 +1054,8 @@ struct nfsd4_operation {
>  	char *op_name;
>  	/* Try to get response size before operation */
>  	nfsd4op_rsize op_rsize_bop;
> -	stateid_setter op_get_currentstateid;
> -	stateid_getter op_set_currentstateid;
> +	stateid_getter op_get_currentstateid;
> +	stateid_setter op_set_currentstateid;
>  };
>  
>  static struct nfsd4_operation nfsd4_ops[];
> -- 
> 1.7.11.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
index c9c1c0a..f2bb0ef 100644
--- a/fs/nfsd/nfs4proc.c
+++ b/fs/nfsd/nfs4proc.c
@@ -1054,8 +1054,8 @@  struct nfsd4_operation {
 	char *op_name;
 	/* Try to get response size before operation */
 	nfsd4op_rsize op_rsize_bop;
-	stateid_setter op_get_currentstateid;
-	stateid_getter op_set_currentstateid;
+	stateid_getter op_get_currentstateid;
+	stateid_setter op_set_currentstateid;
 };
 
 static struct nfsd4_operation nfsd4_ops[];