diff mbox

nfs: fix wrong object type in lockowner_slab

Message ID 1351061059-29318-1-git-send-email-ycnian@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

ycnian@gmail.com Oct. 24, 2012, 6:44 a.m. UTC 
From: Yanchuan Nian <ycnian@gmail.com>

The object type in the cache of lockowner_slab is wrong, and it is better to fix it.

Signed-off-by: Yanchuan Nian <ycnian@gmail.com>
---
 fs/nfsd/nfs4state.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

J. Bruce Fields Oct. 24, 2012, 7:42 p.m. UTC | #1 
On Wed, Oct 24, 2012 at 02:44:19PM +0800, ycnian@gmail.com wrote:
> From: Yanchuan Nian <ycnian@gmail.com>
> 
> The object type in the cache of lockowner_slab is wrong, and it is better to fix it.
> 
> Signed-off-by: Yanchuan Nian <ycnian@gmail.com>
> ---
>  fs/nfsd/nfs4state.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index cc894ed..1609eb2 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -2325,7 +2325,7 @@ nfsd4_init_slabs(void)
>  	if (openowner_slab == NULL)
>  		goto out_nomem;
>  	lockowner_slab = kmem_cache_create("nfsd4_lockowners",
> -			sizeof(struct nfs4_openowner), 0, 0, NULL);
> +			sizeof(struct nfs4_lockowner), 0, 0, NULL);

Thanks!

The first three fields of each are the same, the rest is:

	struct nfs4_openowner {
		...
		pointer
		time_t
		unsigned char
	}

	struct nfs4_lockowner {
		...
		struct list_head
	}

Is it always true that

	sizeof(struct nfs4_openowner) >= sizeof9struct nfs4_lockowner)

?  I think so, in which case this isn't urgent.... Applying for 3.8.

--b.

>  	if (lockowner_slab == NULL)
>  		goto out_nomem;
>  	file_slab = kmem_cache_create("nfsd4_files",
> -- 
> 1.7.4.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index cc894ed..1609eb2 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -2325,7 +2325,7 @@  nfsd4_init_slabs(void)
 	if (openowner_slab == NULL)
 		goto out_nomem;
 	lockowner_slab = kmem_cache_create("nfsd4_lockowners",
-			sizeof(struct nfs4_openowner), 0, 0, NULL);
+			sizeof(struct nfs4_lockowner), 0, 0, NULL);
 	if (lockowner_slab == NULL)
 		goto out_nomem;
 	file_slab = kmem_cache_create("nfsd4_files",