From patchwork Sat Oct 27 12:33:26 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 1655321 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id DE1E8DFAC4 for ; Sat, 27 Oct 2012 12:39:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756070Ab2J0MjB (ORCPT ); Sat, 27 Oct 2012 08:39:01 -0400 Received: from mail-yh0-f46.google.com ([209.85.213.46]:55832 "EHLO mail-yh0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756016Ab2J0MeZ (ORCPT ); Sat, 27 Oct 2012 08:34:25 -0400 Received: by mail-yh0-f46.google.com with SMTP id m54so691039yhm.19 for ; Sat, 27 Oct 2012 05:34:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=8xZ0ZyHv4vg6TdEyxt//DyDlnCdmumHIjrM1wJfkfhM=; b=M85SdAY2kYpV4kP6NL7BPbKEHhUdL0/fTHOcnugP4MBxZuGKsTwdmg5cAjAM+EyPD2 8aDMV7EJ5kzt+XT6OupxC0fQhDZZZYtCkoeTTfDvFC99R46s9v71nxrb7NXwqKeK4cMw FaIZERiXWY1PLUHGP1lDFi0IVlBtg5mXvztYAT46rK+57eXJgOScYhYyfpj2LmjilXQr L8Sk2s+ChR9pyu+Kt4GpoO7vwB5CVFQu8QennX1bCEm0W4E41x6q0zeb3yWvN6AkFvMa roBqmfmqorFTl43acjjL2ZG/swUKOOfXTEhFdo2XgNlcr7NsfRB0HUEaxotmVaIdqWNq Mefg== Received: by 10.101.136.14 with SMTP id o14mr7691021ann.27.1351341264620; Sat, 27 Oct 2012 05:34:24 -0700 (PDT) Received: from salusa.poochiereds.net (cpe-107-015-110-129.nc.res.rr.com. [107.15.110.129]) by mx.google.com with ESMTPS id f15sm4124613yhi.11.2012.10.27.05.34.23 (version=SSLv3 cipher=OTHER); Sat, 27 Oct 2012 05:34:24 -0700 (PDT) From: Jeff Layton To: viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, michael.brantley@deshaw.com, hch@infradead.org, miklos@szeredi.hu, pstaubach@exagrid.com Subject: [PATCH v8 19/32] vfs: fix user_statfs to retry once on ESTALE errors Date: Sat, 27 Oct 2012 08:33:26 -0400 Message-Id: <1351341219-17837-20-git-send-email-jlayton@redhat.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1351341219-17837-1-git-send-email-jlayton@redhat.com> References: <1351341219-17837-1-git-send-email-jlayton@redhat.com> X-Gm-Message-State: ALoCoQkorwdFCgZ6pcf+JP6RfA4atnWv3qSuYwA2gzd1DriQBDrGaUu9rK9ylW9Bh/5eZGcYTajE Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Signed-off-by: Jeff Layton --- fs/statfs.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/fs/statfs.c b/fs/statfs.c index f8e832e..7b42ca3 100644 --- a/fs/statfs.c +++ b/fs/statfs.c @@ -77,11 +77,19 @@ EXPORT_SYMBOL(vfs_statfs); int user_statfs(const char __user *pathname, struct kstatfs *st) { struct path path; - int error = user_path_at(AT_FDCWD, pathname, LOOKUP_FOLLOW|LOOKUP_AUTOMOUNT, &path); - if (!error) { + int error; + unsigned int try = 0; + unsigned int lookup_flags = LOOKUP_FOLLOW|LOOKUP_AUTOMOUNT; + + do { + error = user_path_at(AT_FDCWD, pathname, lookup_flags, &path); + if (error) + break; + error = vfs_statfs(&path, st); path_put(&path); - } + lookup_flags |= LOOKUP_REVAL; + } while (retry_estale(error, try++)); return error; }