diff mbox

[RFC,v0,45/49] nfs: resolve compile dependency in nfs_xdr.h

Message ID 1380220979-14761-1-git-send-email-bhalevy@primarydata.com (mailing list archive)
State New, archived
Headers show

Commit Message

Benny Halevy Sept. 26, 2013, 6:42 p.m. UTC 
From: Benny Halevy <bhalevy@panasas.com>

Include headers in nfs_xdr.h required for
struct rpc_task, nfs4_verifier, nfs4_stateid

Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Benny Halevy <bhalevy@panasas.com>
[add more includes needed since v3.4-rc]
Signed-off-by: Benny Halevy <bhalevy@primarydata.com>
---
 include/linux/nfs_xdr.h | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Christoph Hellwig Sept. 29, 2013, 12:19 p.m. UTC | #1 
On Thu, Sep 26, 2013 at 02:42:59PM -0400, Benny Halevy wrote:
> From: Benny Halevy <bhalevy@panasas.com>
> 
> Include headers in nfs_xdr.h required for
> struct rpc_task, nfs4_verifier, nfs4_stateid

Is this actually dereferences or would it need a forward declaration?

Also should go to Trond straight outside of this series.

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Benny Halevy Oct. 2, 2013, 2:19 p.m. UTC | #2 
On 2013-09-29 15:19, Christoph Hellwig wrote:
> On Thu, Sep 26, 2013 at 02:42:59PM -0400, Benny Halevy wrote:
>> From: Benny Halevy <bhalevy@panasas.com>
>>
>> Include headers in nfs_xdr.h required for
>> struct rpc_task, nfs4_verifier, nfs4_stateid
> 
> Is this actually dereferences or would it need a forward declaration?
> 
> Also should go to Trond straight outside of this series.

Hmm, I thought I already replied to this, but I don't see my reply,
so here it is :)

I consulted with Trond about this and there's a better way to
get the definition here by including linux/nfs4.h that doesn't require
the nfs_xdr.h baggage.  So this patch is dropped from the next
version.

Benny

> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/linux/nfs_xdr.h b/include/linux/nfs_xdr.h
index 01fd84b..93cbda7 100644
--- a/include/linux/nfs_xdr.h
+++ b/include/linux/nfs_xdr.h
@@ -3,6 +3,10 @@ 
 
 #include <linux/nfsacl.h>
 #include <linux/sunrpc/gss_api.h>
+#include <linux/nfs.h>
+#include <linux/nfs3.h>
+#include <linux/nfs4.h>
+#include <linux/sunrpc/sched.h>
 
 /*
  * To change the maximum rsize and wsize supported by the NFS client, adjust