From patchwork Tue Oct 29 09:39:04 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benny Halevy X-Patchwork-Id: 3106991 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6AD409F431 for ; Tue, 29 Oct 2013 09:39:20 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DF6D4202B8 for ; Tue, 29 Oct 2013 09:39:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B60D820253 for ; Tue, 29 Oct 2013 09:39:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753719Ab3J2JjN (ORCPT ); Tue, 29 Oct 2013 05:39:13 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:55748 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753717Ab3J2JjM (ORCPT ); Tue, 29 Oct 2013 05:39:12 -0400 Received: by mail-wi0-f180.google.com with SMTP id ey11so5035160wid.1 for ; Tue, 29 Oct 2013 02:39:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=ezPEciwunKyVX4XDEYTWXJY16f/8awyhzu/gqCJ4aXU=; b=CP/AGxFkiCcyYGahzgBGVmTiSpRiRF7+VhnECJTKlO67BKlsNBAPPKGuh9KUf34RQC myOQc9wo59d9d+t/iOubP3ItHnLnAxbIkC4NGgdpRSWHEzNkMTcjAlh+QKznP2S6mTvq Od2mS7EGpx2cNF4RsgxVEuv1Kpp0NEfxQRafiES3Mn11B2hGlQ4GtF2zHjvH2kyuK74C ctngudefAs4lPQDPyb2VbnM8Pda4AlSj3CWZ9X+U6rVinXKP13N9ds45aMJ4Uu6LCoXd dhp+Dld0nM7G0yhxAw1eZ3TCFtDTaAT/we4KvzcRKsIp1SAReUIiJwOZzkUmFjP9cLcN /zGg== X-Received: by 10.194.19.228 with SMTP id i4mr367687wje.87.1383039550868; Tue, 29 Oct 2013 02:39:10 -0700 (PDT) Received: from bhalevy-lt.il.tonian.com (bzq-80-49-130.static.bezeqint.net. [82.80.49.130]) by mx.google.com with ESMTPSA id b7sm2989203wiz.8.2013.10.29.02.39.08 for (version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128/128); Tue, 29 Oct 2013 02:39:09 -0700 (PDT) From: Benny Halevy To: bfields@redhat.com Cc: linux-nfs@vger.kernel.org, Benny Halevy Subject: [PATCH 1/7] nfsd4: fix recall_lock use in unhash_delegation Date: Tue, 29 Oct 2013 11:39:04 +0200 Message-Id: <1383039544-27157-1-git-send-email-bhalevy@primarydata.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <526F81DE.6060704@primarydata.com> References: <526F81DE.6060704@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Access to dp->dl_perclnt must be synchronized by the recall_lock Signed-off-by: Benny Halevy --- fs/nfsd/nfs4state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index a90949a..a403502 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -436,8 +436,8 @@ static void unhash_stid(struct nfs4_stid *s) static void unhash_delegation(struct nfs4_delegation *dp) { - list_del_init(&dp->dl_perclnt); spin_lock(&recall_lock); + list_del_init(&dp->dl_perclnt); list_del_init(&dp->dl_perfile); list_del_init(&dp->dl_recall_lru); spin_unlock(&recall_lock);