diff mbox

[pynfs] nfs4.1 server: DSs should have diff server owners

Message ID 1392050222-1470-1-git-send-email-dros@primarydata.com (mailing list archive)
State New, archived
Headers show

Commit Message

Weston Andros Adamson Feb. 10, 2014, 4:37 p.m. UTC
Use getpid() to generate the minor_id component of the server owner.

Witout this, all DSs are considered to be the same server by NFS clients
that detect server trunking, such as the upstream Linux client.

Signed-off-by: Weston Andros Adamson <dros@primarydata.com>
---
 nfs4.1/config.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

J. Bruce Fields Feb. 11, 2014, 5:08 p.m. UTC | #1
On Mon, Feb 10, 2014 at 11:37:02AM -0500, Weston Andros Adamson wrote:
> Use getpid() to generate the minor_id component of the server owner.
> 
> Witout this, all DSs are considered to be the same server by NFS clients
> that detect server trunking, such as the upstream Linux client.

Applied and pushed out, thanks.--b.

> 
> Signed-off-by: Weston Andros Adamson <dros@primarydata.com>
> ---
>  nfs4.1/config.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/nfs4.1/config.py b/nfs4.1/config.py
> index 4f91e84..2238aee 100644
> --- a/nfs4.1/config.py
> +++ b/nfs4.1/config.py
> @@ -3,6 +3,7 @@ from nfs4_const import *
>  import nfs4_const
>  import nfs4lib
>  from copy import deepcopy
> +import os
>  
>  class ConfigAction(Exception):
>      pass
> @@ -129,7 +130,7 @@ class ServerConfig(object):
>                ]
>  
>      def __init__(self):
> -        self.minor_id = 0
> +        self.minor_id = os.getpid()
>          self.major_id = "PyNFSv4.1"
>          self._owner = server_owner4(self.minor_id, self.major_id)
>          self.scope = "Default_Scope"
> -- 
> 1.8.3.4 (Apple Git-47)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/nfs4.1/config.py b/nfs4.1/config.py
index 4f91e84..2238aee 100644
--- a/nfs4.1/config.py
+++ b/nfs4.1/config.py
@@ -3,6 +3,7 @@  from nfs4_const import *
 import nfs4_const
 import nfs4lib
 from copy import deepcopy
+import os
 
 class ConfigAction(Exception):
     pass
@@ -129,7 +130,7 @@  class ServerConfig(object):
               ]
 
     def __init__(self):
-        self.minor_id = 0
+        self.minor_id = os.getpid()
         self.major_id = "PyNFSv4.1"
         self._owner = server_owner4(self.minor_id, self.major_id)
         self.scope = "Default_Scope"