From patchwork Mon Nov 3 20:19:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Weston Andros Adamson X-Patchwork-Id: 5219631 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A8F5A9F349 for ; Mon, 3 Nov 2014 20:19:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D7DA02013A for ; Mon, 3 Nov 2014 20:19:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B5E8A20136 for ; Mon, 3 Nov 2014 20:19:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752520AbaKCUTv (ORCPT ); Mon, 3 Nov 2014 15:19:51 -0500 Received: from mail-ie0-f172.google.com ([209.85.223.172]:59741 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752458AbaKCUTv (ORCPT ); Mon, 3 Nov 2014 15:19:51 -0500 Received: by mail-ie0-f172.google.com with SMTP id at20so6032885iec.31 for ; Mon, 03 Nov 2014 12:19:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=PCOJ4a6oqxCQooMFj2bh76V1z1OGMkQedhQD0siDuj0=; b=kCpjjjSgBlCja8ghZ07zzeCxekojRCFUU873G/0fYRsdl47GTKgWgIWfvFS5C1X1Wb Pwq3LpDA+wcmOPKArhVWBJLAw709gBKAs7QxxZa5t2GZ9fDxnnuDFyoIT2AqiufNhCwN IoYAFac+4UVxEE9bFwEwpQKlS4m2qR5Zlqk26TTNBuqc79nteNzCThUMxlvJTdBrrfd1 yw5fdXQfrY42U4s3T1GrmxDZIEx+HeuM7Vsf6O+SMd//MqO59ZBbUteb1TtUAY5LLrxB vGKhqfZyheCNxhAUmW8uv5yDknPj3AhYKkxAOwwKiAWXESSNNaxwmjAHDEQWSeug1Cm5 KcBQ== X-Gm-Message-State: ALoCoQnvile8dxlJaa9Mdm1hi3Xv7EPVIXsYjbZvHKy73E5M2TQbBps0mBoyJBUN7IP4u9kxnXys X-Received: by 10.42.129.140 with SMTP id q12mr3605174ics.68.1415045990415; Mon, 03 Nov 2014 12:19:50 -0800 (PST) Received: from gavrio.lan ([71.205.60.49]) by mx.google.com with ESMTPSA id m63sm9421812ioe.40.2014.11.03.12.19.49 for (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Nov 2014 12:19:49 -0800 (PST) From: Weston Andros Adamson To: trond.myklebust@primarydata.com Cc: linux-nfs@vger.kernel.org, Weston Andros Adamson Subject: [PATCH] nfs: remove spurious WARN_ON_ONCE in write path Date: Mon, 3 Nov 2014 15:19:45 -0500 Message-Id: <1415045985-60963-1-git-send-email-dros@primarydata.com> X-Mailer: git-send-email 1.9.3 (Apple Git-50) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This WARN_ON_ONCE was supposed to catch reference counting bugs, but can trigger in inappropriate situations. This was reproducible using NFSv2 on an architecture with 64K pages -- we verified that it was not a reference counting bug and the warning was safe to ignore. Reported-by: Will Deacon Tested-by: Will Deacon Signed-off-by: Weston Andros Adamson --- fs/nfs/write.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/nfs/write.c b/fs/nfs/write.c index 12493846a2d3..f83b02dc9166 100644 --- a/fs/nfs/write.c +++ b/fs/nfs/write.c @@ -715,8 +715,6 @@ static void nfs_inode_remove_request(struct nfs_page *req) if (test_and_clear_bit(PG_INODE_REF, &req->wb_flags)) nfs_release_request(req); - else - WARN_ON_ONCE(1); } static void