From patchwork Tue Dec 16 19:01:32 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Haynes X-Patchwork-Id: 5503031 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id EDD9ABEEA8 for ; Tue, 16 Dec 2014 19:03:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1ABEE209C1 for ; Tue, 16 Dec 2014 19:03:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 42DE1209BD for ; Tue, 16 Dec 2014 19:02:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751297AbaLPTC6 (ORCPT ); Tue, 16 Dec 2014 14:02:58 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:51956 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751265AbaLPTC5 (ORCPT ); Tue, 16 Dec 2014 14:02:57 -0500 Received: by mail-pa0-f43.google.com with SMTP id kx10so14632837pab.16 for ; Tue, 16 Dec 2014 11:02:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TNEz3ETvSS9eII4RkPJawt3TyFcvkCZHthBn74krFf8=; b=CaBERZUhGIsCxE8O+j9lhB4e5ICT7CBjmU4ChXGfKL57blYLTi+IoMIeVEz3XSBXCM 2OeTbYfolOmbV7tiBFU8y4iwwAijWPo43rTOxAjLsDLzHbgE9GyRag8M71E5Dn4eoX4y X0rSGEKNtGofB32uCzbQX4kK0vO5XTNScHzzpSw0qYqbcaS8Y1gK00bE65rIF4s9+LKZ GfDhvlbEqnvQXym/vKsSZma3hOAaLGNcYVViYTFLRBsHi6xKbx3w0NQ9uyiBNpkuxF81 7x2WoyLcNr1YVBGgHtOvQvzsAjcD4rM/2iPiVEX5PpUwNAn5itcbvuJh00XM2G8iRWVX V2ag== X-Gm-Message-State: ALoCoQkjC3EEVvemH2fzbnwnzaY0d60gPFTnsvk/yOmxtr9b4cXx3P+msACSOqGbwj873rmjgrdk X-Received: by 10.66.120.129 with SMTP id lc1mr63888027pab.86.1418756576437; Tue, 16 Dec 2014 11:02:56 -0800 (PST) Received: from localhost.localdomain ([50.242.95.105]) by mx.google.com with ESMTPSA id q4sm1620669pdh.79.2014.12.16.11.02.55 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Dec 2014 11:02:55 -0800 (PST) From: Tom Haynes X-Google-Original-From: Tom Haynes To: Trond Myklebust Cc: Linux NFS Mailing List Subject: [PATCH 29/50] nfs/filelayout: use pnfs_error_mark_layout_for_return Date: Tue, 16 Dec 2014 11:01:32 -0800 Message-Id: <1418756513-95187-30-git-send-email-loghyr@primarydata.com> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1418756513-95187-1-git-send-email-loghyr@primarydata.com> References: <1418756513-95187-1-git-send-email-loghyr@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Peng Tao Instead of calling layoutreturn directly, call pnfs_error_mark_layout_for_return to mark layouts for return and let generic code return layout when layout segments are freed. Signed-off-by: Peng Tao Signed-off-by: Tom Haynes Conflicts: fs/nfs/filelayout/filelayout.c --- fs/nfs/filelayout/filelayout.c | 2 +- fs/nfs/pnfs_nfsio.c | 10 ---------- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/fs/nfs/filelayout/filelayout.c b/fs/nfs/filelayout/filelayout.c index bfa8547..5d2eadc 100644 --- a/fs/nfs/filelayout/filelayout.c +++ b/fs/nfs/filelayout/filelayout.c @@ -200,7 +200,7 @@ static int filelayout_async_handle_error(struct rpc_task *task, dprintk("%s DS connection error %d\n", __func__, task->tk_status); nfs4_mark_deviceid_unavailable(devid); - set_bit(NFS_LAYOUT_RETURN, &lo->plh_flags); + pnfs_error_mark_layout_for_return(inode, lseg); rpc_wake_up(&tbl->slot_tbl_waitq); /* fall through */ default: diff --git a/fs/nfs/pnfs_nfsio.c b/fs/nfs/pnfs_nfsio.c index 329447c..c6c3efc 100644 --- a/fs/nfs/pnfs_nfsio.c +++ b/fs/nfs/pnfs_nfsio.c @@ -13,20 +13,10 @@ #include "internal.h" #include "pnfs.h" -static void pnfs_generic_fenceme(struct inode *inode, - struct pnfs_layout_hdr *lo) -{ - if (!test_and_clear_bit(NFS_LAYOUT_RETURN, &lo->plh_flags)) - return; - pnfs_return_layout(inode); -} - void pnfs_generic_rw_release(void *data) { struct nfs_pgio_header *hdr = data; - struct pnfs_layout_hdr *lo = hdr->lseg->pls_layout; - pnfs_generic_fenceme(lo->plh_inode, lo); nfs_put_client(hdr->ds_clp); hdr->mds_ops->rpc_release(data); }