diff mbox

rpc.gssd: Replace exit(0) by return in process_krb5_upcall

Message ID 1440014300-1502-1-git-send-email-andros@netapp.com (mailing list archive)
State New, archived
Headers show

Commit Message

Andy Adamson Aug. 19, 2015, 7:58 p.m. UTC 
From: Andy Adamson <andros@netapp.com>

exit(0) silenty reaps the gssd_k5_kt_princ struct, the in-memory
rpc.gssd cache which means that rpc.gssd will get a new TGT and TGS for
each upcall, ignoring a valid TGT in the kerberos credential cache.

Signed-off-by: Andy Adamson <andros@netapp.com>
---
 utils/gssd/gssd_proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Steve Dickson Aug. 24, 2015, 5:51 p.m. UTC | #1 
On 08/19/2015 03:58 PM, andros@netapp.com wrote:
> From: Andy Adamson <andros@netapp.com>
> 
> exit(0) silenty reaps the gssd_k5_kt_princ struct, the in-memory
> rpc.gssd cache which means that rpc.gssd will get a new TGT and TGS for
> each upcall, ignoring a valid TGT in the kerberos credential cache.
> 
> Signed-off-by: Andy Adamson <andros@netapp.com>
Committed... 

steved.

> ---
>  utils/gssd/gssd_proc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/gssd/gssd_proc.c b/utils/gssd/gssd_proc.c
> index 03afc8b..3fc7bba 100644
> --- a/utils/gssd/gssd_proc.c
> +++ b/utils/gssd/gssd_proc.c
> @@ -684,7 +684,7 @@ out:
>  		AUTH_DESTROY(auth);
>  	if (rpc_clnt)
>  		clnt_destroy(rpc_clnt);
> -	exit(0);
> +	return;
>  
>  out_return_error:
>  	do_error_downcall(fd, uid, downcall_err);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Steve Dickson Sept. 8, 2015, 3:16 p.m. UTC | #2 
On 08/24/2015 01:51 PM, Steve Dickson wrote:
> 
> 
> On 08/19/2015 03:58 PM, andros@netapp.com wrote:
>> From: Andy Adamson <andros@netapp.com>
>>
>> exit(0) silenty reaps the gssd_k5_kt_princ struct, the in-memory
>> rpc.gssd cache which means that rpc.gssd will get a new TGT and TGS for
>> each upcall, ignoring a valid TGT in the kerberos credential cache.
>>
>> Signed-off-by: Andy Adamson <andros@netapp.com>
> Committed... 
This has been reverted due to child processes not exiting on upcalls.

steved.
> 
> steved.
> 
>> ---
>>  utils/gssd/gssd_proc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/utils/gssd/gssd_proc.c b/utils/gssd/gssd_proc.c
>> index 03afc8b..3fc7bba 100644
>> --- a/utils/gssd/gssd_proc.c
>> +++ b/utils/gssd/gssd_proc.c
>> @@ -684,7 +684,7 @@ out:
>>  		AUTH_DESTROY(auth);
>>  	if (rpc_clnt)
>>  		clnt_destroy(rpc_clnt);
>> -	exit(0);
>> +	return;
>>  
>>  out_return_error:
>>  	do_error_downcall(fd, uid, downcall_err);
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/utils/gssd/gssd_proc.c b/utils/gssd/gssd_proc.c
index 03afc8b..3fc7bba 100644
--- a/utils/gssd/gssd_proc.c
+++ b/utils/gssd/gssd_proc.c
@@ -684,7 +684,7 @@  out:
 		AUTH_DESTROY(auth);
 	if (rpc_clnt)
 		clnt_destroy(rpc_clnt);
-	exit(0);
+	return;
 
 out_return_error:
 	do_error_downcall(fd, uid, downcall_err);