From patchwork Wed Aug 19 19:58:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Adamson X-Patchwork-Id: 7039201 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 351C7C05AC for ; Wed, 19 Aug 2015 20:08:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 488C7207C0 for ; Wed, 19 Aug 2015 20:08:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 47059207BD for ; Wed, 19 Aug 2015 20:08:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751929AbbHSUI1 (ORCPT ); Wed, 19 Aug 2015 16:08:27 -0400 Received: from mx143.netapp.com ([216.240.21.24]:33468 "EHLO mx143.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751887AbbHSUI0 (ORCPT ); Wed, 19 Aug 2015 16:08:26 -0400 X-Greylist: delayed 571 seconds by postgrey-1.27 at vger.kernel.org; Wed, 19 Aug 2015 16:08:26 EDT X-IronPort-AV: E=Sophos;i="5.15,712,1432623600"; d="scan'208";a="61784977" Received: from vmwexchts04-prd.hq.netapp.com ([10.122.105.32]) by mx143-out.netapp.com with ESMTP; 19 Aug 2015 12:58:55 -0700 Received: from smtp2.corp.netapp.com (10.57.159.114) by VMWEXCHTS04-PRD.hq.netapp.com (10.122.105.32) with Microsoft SMTP Server id 15.0.1076.9; Wed, 19 Aug 2015 12:58:54 -0700 Received: from andros-new.vpn.netapp.com (andros-new.vpn.netapp.com [10.55.74.200]) by smtp2.corp.netapp.com (8.13.1/8.13.1/NTAP-1.6) with ESMTP id t7JJwrTt017051; Wed, 19 Aug 2015 12:58:54 -0700 (PDT) From: To: CC: , Andy Adamson Subject: [PATCH] rpc.gssd: Replace exit(0) by return in process_krb5_upcall Date: Wed, 19 Aug 2015 15:58:20 -0400 Message-ID: <1440014300-1502-1-git-send-email-andros@netapp.com> X-Mailer: git-send-email 1.9.3 (Apple Git-50) MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Andy Adamson exit(0) silenty reaps the gssd_k5_kt_princ struct, the in-memory rpc.gssd cache which means that rpc.gssd will get a new TGT and TGS for each upcall, ignoring a valid TGT in the kerberos credential cache. Signed-off-by: Andy Adamson --- utils/gssd/gssd_proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/gssd/gssd_proc.c b/utils/gssd/gssd_proc.c index 03afc8b..3fc7bba 100644 --- a/utils/gssd/gssd_proc.c +++ b/utils/gssd/gssd_proc.c @@ -684,7 +684,7 @@ out: AUTH_DESTROY(auth); if (rpc_clnt) clnt_destroy(rpc_clnt); - exit(0); + return; out_return_error: do_error_downcall(fd, uid, downcall_err);