From patchwork Wed Aug 26 08:16:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Tao X-Patchwork-Id: 7075281 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8B0C3C05AC for ; Wed, 26 Aug 2015 08:19:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B15EB205C4 for ; Wed, 26 Aug 2015 08:19:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BDCB8208EB for ; Wed, 26 Aug 2015 08:19:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756615AbbHZITo (ORCPT ); Wed, 26 Aug 2015 04:19:44 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:36233 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756589AbbHZITO (ORCPT ); Wed, 26 Aug 2015 04:19:14 -0400 Received: by pacgr6 with SMTP id gr6so1413265pac.3 for ; Wed, 26 Aug 2015 01:19:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=83j6mUFhsKXZdjCqDSeJdvDqMc7EKOpugC75x68HzQA=; b=Bq3yymIRPm0LGGWcTGcgd5C9NO7kr2HPTnXjGeCZRlRZey3qEtEGVVz7Lhl8jNHyU8 6m8XwYb2cq9/jJpMjc2YIE112QTf7XG/aAH/lCuZ4TCW7lvElh0Sist9nmEfbwq+LTww FEeep7SnPVpu89iKOzIj0y4G7Kg0xbvK81njEDgouPIs4jPF4HX+0zPOfFnXDeJtnN6G cJyS6fI83oZRbnrzEfUwHIjmeBo/uH8Ax9ZsrFdSLDw+Y6kkPys7Q/mCj640Wd+ODTR1 UBk+3611eRbDNDQWe+yTILQoo65J+gVUJPQ0OtJ/MrZdOhOgcIs5gJOsfHmsmM4W0LLX vC3A== X-Gm-Message-State: ALoCoQlE6pdwU8QN3TsJDpUTlQiVVOlfpyBS3MU5eWSARadFp8tRvW1UinYw3d5kmY3Pat9+e6oD X-Received: by 10.69.26.161 with SMTP id iz1mr67550871pbd.17.1440577154507; Wed, 26 Aug 2015 01:19:14 -0700 (PDT) Received: from lear.localdomain (ec2-54-65-164-9.ap-northeast-1.compute.amazonaws.com. [54.65.164.9]) by smtp.gmail.com with ESMTPSA id a2sm23689455pbu.41.2015.08.26.01.19.10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Aug 2015 01:19:14 -0700 (PDT) From: Peng Tao To: linux-fsdevel@vger.kernel.org Cc: Trond Myklebust , Anna Schumaker , Christoph Hellwig , Zach Brown , Darren Hart , bfields@fieldses.org, Jeff Layton , linux-nfs@vger.kernel.org, "Darrick J. Wong" , linux-btrfs@vger.kernel.org, Peng Tao Subject: [PATCH-RFC-RESEND 7/9] nfs42: respect clone_blksize Date: Wed, 26 Aug 2015 16:16:48 +0800 Message-Id: <1440577010-122867-8-git-send-email-tao.peng@primarydata.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1440577010-122867-1-git-send-email-tao.peng@primarydata.com> References: <1440577010-122867-1-git-send-email-tao.peng@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP draft-ietf-nfsv4-minorversion2-38.txt says: Both cl_src_offset and cl_dst_offset must be aligned to the clone block size Section 12.2.1. The number of bytes to be cloned must be a multiple of the clone block size, except in the case in which cl_src_offset plus the number of bytes to be cloned is equal to the source file size. Signed-off-by: Peng Tao --- fs/nfs/nfs4file.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/fs/nfs/nfs4file.c b/fs/nfs/nfs4file.c index c335cb0..ee8c014 100644 --- a/fs/nfs/nfs4file.c +++ b/fs/nfs/nfs4file.c @@ -174,12 +174,20 @@ nfs42_file_clone_range(struct file *src_file, struct file *dst_file, { struct inode *dst_inode = file_inode(dst_file); struct inode *src_inode = file_inode(src_file); + struct nfs_server *server = NFS_SERVER(dst_inode); + unsigned int bs = server->clone_blksize; int ret; /* src and dst must be different files */ if (src_inode == dst_inode) return -EINVAL; + /* check alignment w.r.t. clone_blksize */ + if (bs) + if (!IS_ALIGNED(src_off, bs) || !IS_ALIGNED(dst_off, bs) || + (!IS_ALIGNED(count, bs) && i_size_read(src_inode) != (src_off + count))) + return -EINVAL; + /* XXX: do we lock at all? what if server needs CB_RECALL_LAYOUT? */ if (dst_inode < src_inode) { mutex_lock_nested(&dst_inode->i_mutex, I_MUTEX_PARENT);