From patchwork Thu Sep 17 12:39:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 7206451 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1FF629F336 for ; Thu, 17 Sep 2015 12:41:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4BF0D20695 for ; Thu, 17 Sep 2015 12:41:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D28B20671 for ; Thu, 17 Sep 2015 12:41:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752114AbbIQMlC (ORCPT ); Thu, 17 Sep 2015 08:41:02 -0400 Received: from mail-yk0-f177.google.com ([209.85.160.177]:36451 "EHLO mail-yk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751907AbbIQMj5 (ORCPT ); Thu, 17 Sep 2015 08:39:57 -0400 Received: by ykdt18 with SMTP id t18so15060507ykd.3 for ; Thu, 17 Sep 2015 05:39:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kaKg6KCGE8H8G5SRQ9Fp0XRqFUqU6uuoWe6eg53jQyY=; b=dJuUHcbf4Zb0ufHIUWu+o0/pjtEv0/caxw59z3Lex95yW2BJIv3nVz1Aau1q4pqNs1 UN5mhFK+ay/pRlCH/yRAgtv1aTTbV4rW4UKI3iLz4xhDw+fTktHUcy+IsEJDxPCkIEYS 9zCCLmcH3vKkfSRMx4WPeBlJ/sqeo805ctffWgys4ZkkzklxKSKLtIQjn0ZMXsjXfIDF rJipIvcZBxaRqiNCD8T2O7ixJ8XgUEHx/1bI/iyd9PuPjnbfxvHLdQPIl1KTPLYYhYjx AwbRe4uBcdL20QpJ6bmtcXIDnn+xjkv0jSgBoBwQfQx7gq2eCGrK5O1LrEVuqbvGapjA tNFA== X-Gm-Message-State: ALoCoQlgEAQ660s4K7VUREKofSfKcF4yoabpIFq/yB3bA8jinqGYJpC05ms9caXpteVlEb7/jTqN X-Received: by 10.129.90.214 with SMTP id o205mr32425123ywb.32.1442493597374; Thu, 17 Sep 2015 05:39:57 -0700 (PDT) Received: from tlielax.poochiereds.net ([2606:a000:1105:8e:3a60:77ff:fe93:a95d]) by smtp.googlemail.com with ESMTPSA id q128sm1878652ywf.27.2015.09.17.05.39.56 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Sep 2015 05:39:56 -0700 (PDT) From: Jeff Layton X-Google-Original-From: Jeff Layton To: Al Viro Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/4] fs: export flush_delayed_fput Date: Thu, 17 Sep 2015 08:39:47 -0400 Message-Id: <1442493587-32499-5-git-send-email-jeff.layton@primarydata.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1442493587-32499-1-git-send-email-jeff.layton@primarydata.com> References: <1442493587-32499-1-git-send-email-jeff.layton@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP ...and clean up the comments over it a bit. The nfsd code will need to be able to call back into this. Signed-off-by: Jeff Layton --- fs/file_table.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/fs/file_table.c b/fs/file_table.c index 95361d2b8a08..899c19687cfa 100644 --- a/fs/file_table.c +++ b/fs/file_table.c @@ -246,20 +246,24 @@ static void ____fput(struct callback_head *work) static DECLARE_DELAYED_WORK(delayed_fput_work, delayed_fput); -/* - * If kernel thread really needs to have the final fput() it has done - * to complete, call this. The only user right now is the boot - we - * *do* need to make sure our writes to binaries on initramfs has - * not left us with opened struct file waiting for __fput() - execve() - * won't work without that. Please, don't add more callers without - * very good reasons; in particular, never call that with locks - * held and never call that from a thread that might need to do - * some work on any kind of umount. +/** + * flush_delayed_fput - ensure that all delayed_fput work is complete + * + * If kernel thread or task that has used fput_queue really needs to have the + * final fput() it has done to complete, call this. One of the main users is + * the boot - we *do* need to make sure our writes to binaries on initramfs has + * not left us with opened struct file waiting for __fput() - execve() won't + * work without that. + * + * Please, don't add more callers without very good reasons; in particular, + * never call that with locks held and never from a thread that might need to + * do some work on any kind of umount. */ void flush_delayed_fput(void) { flush_delayed_work(&delayed_fput_work); } +EXPORT_SYMBOL(flush_delayed_fput); /** * fput - put a struct file reference