diff mbox

[nfs-utils] exportfs: Restore the EAI_NONAME check in host_pton()

Message ID 1446052796-10287-1-git-send-email-smayhew@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Scott Mayhew Oct. 28, 2015, 5:19 p.m. UTC
Commit d89e3fc7 removed the EAI_NONAME check altogether instead of just
moving the NULL check.  This causes exportfs -u to incorrectly exit
with 1 whenever there's more than one MCL_FQDN export in the exportlist.

Signed-off-by: Scott Mayhew <smayhew@redhat.com>
---
 support/export/hostname.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Steve Dickson Nov. 4, 2015, 9:51 p.m. UTC | #1
On 10/28/2015 01:19 PM, Scott Mayhew wrote:
> Commit d89e3fc7 removed the EAI_NONAME check altogether instead of just
> moving the NULL check.  This causes exportfs -u to incorrectly exit
> with 1 whenever there's more than one MCL_FQDN export in the exportlist.
> 
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
Committed... 

steved.
> ---
>  support/export/hostname.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/support/export/hostname.c b/support/export/hostname.c
> index 169baa5..7a44d42 100644
> --- a/support/export/hostname.c
> +++ b/support/export/hostname.c
> @@ -134,6 +134,8 @@ host_pton(const char *paddr)
>  			break;
>  		}
>  		return ai;
> +	case EAI_NONAME:
> +		break;
>  	case EAI_SYSTEM:
>  		xlog(D_GENERAL, "%s: failed to convert %s: (%d) %m",
>  				__func__, paddr, errno);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/support/export/hostname.c b/support/export/hostname.c
index 169baa5..7a44d42 100644
--- a/support/export/hostname.c
+++ b/support/export/hostname.c
@@ -134,6 +134,8 @@  host_pton(const char *paddr)
 			break;
 		}
 		return ai;
+	case EAI_NONAME:
+		break;
 	case EAI_SYSTEM:
 		xlog(D_GENERAL, "%s: failed to convert %s: (%d) %m",
 				__func__, paddr, errno);