From patchwork Sat Feb 13 12:54:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Dickson X-Patchwork-Id: 8299871 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 7B02F9F38B for ; Sat, 13 Feb 2016 12:55:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A2E472040F for ; Sat, 13 Feb 2016 12:54:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 778C5203FB for ; Sat, 13 Feb 2016 12:54:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751182AbcBMMyd (ORCPT ); Sat, 13 Feb 2016 07:54:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44567 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751167AbcBMMyd (ORCPT ); Sat, 13 Feb 2016 07:54:33 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 6164014A81 for ; Sat, 13 Feb 2016 12:54:33 +0000 (UTC) Received: from steved.boston.devel.redhat.com (vpn-56-162.rdu2.redhat.com [10.10.56.162]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1DCsWPb014005 for ; Sat, 13 Feb 2016 07:54:32 -0500 From: Steve Dickson To: Linux NFS Mailing list Subject: [PATCH] nfsidmapd: allow the usage message to be displayed Date: Sat, 13 Feb 2016 07:54:31 -0500 Message-Id: <1455368071-15198-1-git-send-email-steved@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP xlog_err() never returns. Change the xlog_err(), when invalid arguments are use, to xlog_warn() so the second xlog_warn, displaying the usage, will be called. Signed-off-by: Steve Dickson --- utils/nfsidmap/nfsidmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/nfsidmap/nfsidmap.c b/utils/nfsidmap/nfsidmap.c index d980c68..2abefe9 100644 --- a/utils/nfsidmap/nfsidmap.c +++ b/utils/nfsidmap/nfsidmap.c @@ -430,7 +430,7 @@ int main(int argc, char **argv) xlog_stderr(verbose); if ((argc - optind) != 2) { - xlog_err("Bad arg count. Check /etc/request-key.conf"); + xlog_warn("Bad arg count. Check /etc/request-key.conf"); xlog_warn(usage, progname); return EXIT_FAILURE; }