From patchwork Wed Jun 14 12:29:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 9786185 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1E7DF602C9 for ; Wed, 14 Jun 2017 12:29:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 11B8528585 for ; Wed, 14 Jun 2017 12:29:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 034A428634; Wed, 14 Jun 2017 12:29:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4868028585 for ; Wed, 14 Jun 2017 12:29:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751829AbdFNM3Q (ORCPT ); Wed, 14 Jun 2017 08:29:16 -0400 Received: from mail-qk0-f176.google.com ([209.85.220.176]:35739 "EHLO mail-qk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751863AbdFNM3P (ORCPT ); Wed, 14 Jun 2017 08:29:15 -0400 Received: by mail-qk0-f176.google.com with SMTP id a199so34131967qkb.2 for ; Wed, 14 Jun 2017 05:29:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=3sZht3+B43WKa9Df1Wbp2TGMd9ejkbSUyEWPTCt3dmc=; b=t5w0EC/4GvyBVWhmJx2MAEF25setmhTmIzcjRCBWXapybXJMPdh2AtGfZc0gw0CbFg rrXo/6+p7sB8i1ZOE6q6oXv3UHrqMmncWdFYRaFO8P2ESgwYnv+J6gFxM5v6vSpJYSty pObVJNJTlIk22YEaY+kEkNYb/POcr15Ot8YpGo9iw1gxfv56hwYMLS6bdfjxq4OUGpcN Sn+RO00grn5t/PP6X5wrgwPyEyKcJvGpTbWUGD1WOOkDvQwlEJNxiPDm5oBoRoq3Zs4f IviVJYYnvyWTgg3s9+ddVQ4ytzAAVegPonWSiMtcfkpbd3ooUgmAAKuuLE/x5hDYs/tX 83dg== X-Gm-Message-State: AKS2vOysl7iB5Iahu2GK0DbBoEcyrsfLUJlAQxryZ40IX/1YyCFdrono 2sf19aqXJB39CtZXAKBsgA== X-Received: by 10.55.120.1 with SMTP id t1mr398519qkc.171.1497443354726; Wed, 14 Jun 2017 05:29:14 -0700 (PDT) Received: from tleilax.poochiereds.net ([2606:a000:1128:8294:3120:4b60:a78f:ae95]) by smtp.gmail.com with ESMTPSA id v131sm379422qka.56.2017.06.14.05.29.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Jun 2017 05:29:14 -0700 (PDT) Message-ID: <1497443353.6752.5.camel@redhat.com> Subject: Re: "nfs4_discover_server_trunking unhandled error" on Ctrl-C From: Jeff Layton To: "Mkrtchyan, Tigran" , Olga Kornievskaia Cc: linux-nfs , Andy Adamson Date: Wed, 14 Jun 2017 08:29:13 -0400 In-Reply-To: <1087115680.14242025.1497381738583.JavaMail.zimbra@desy.de> References: <991293071.14131572.1497360717136.JavaMail.zimbra@desy.de> <1087115680.14242025.1497381738583.JavaMail.zimbra@desy.de> X-Mailer: Evolution 3.24.2 (3.24.2-1.fc26) Mime-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP That warning has been around for a long time. We're running the server trunking check and caught a signal in the middle of it. It's harmless, AFAICT. Should we merge a patch like this (untested) one, just to silence it? It really is an expected situation that we needn't warn anyone about: On Tue, 2017-06-13 at 21:22 +0200, Mkrtchyan, Tigran wrote: > Hi Olga, > > this is 4.12.-rc4. I will check packet capture tomorrow, however, I am pretty sure that > this is client internal interrupt processing. > > Tigran. > > ----- Original Message ----- > > From: "Olga Kornievskaia" > > To: "Tigran Mkrtchyan" > > Cc: "linux-nfs" , "Andy Adamson" > > Sent: Tuesday, June 13, 2017 6:21:01 PM > > Subject: Re: "nfs4_discover_server_trunking unhandled error" on Ctrl-C > > On Tue, Jun 13, 2017 at 9:31 AM, Mkrtchyan, Tigran > > wrote: > > > > > > If I hit Ctrl-C during mount, then I see following message in the log file: > > > > > > NFS: nfs4_discover_server_trunking unhandled error -512. Exiting with error EIO > > > > > > > > > produced at nfs4state.c:2533. Is this expected behavior? > > > > What kernel version (or upstream commit) is that? Is this > > reproducible? Anything on the network trace that server returns that > > could explain an error it doesn't expect. Also I'm thinking that > > nfs_wait_client_init_complete() could be interrupted by ctrl-c and > > return ERESTARTSYS and that could translate to "unhanded error". > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c index b34de036501b..ae9a9ad2894d 100644 --- a/fs/nfs/nfs4state.c +++ b/fs/nfs/nfs4state.c @@ -2182,6 +2182,9 @@ int nfs4_discover_server_trunking(struct nfs_client *clp, * in nfs4_exchange_id */ status = -EKEYEXPIRED; break; + case -ERESTARTSYS: + status = -EINTR; + break; default: pr_warn("NFS: %s unhandled error %d. Exiting with error EIO\n", __func__, status);