From patchwork Thu Oct 7 22:30:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Wysochanski X-Patchwork-Id: 12543699 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C6FBC433FE for ; Thu, 7 Oct 2021 22:32:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6640610A0 for ; Thu, 7 Oct 2021 22:32:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241362AbhJGWef (ORCPT ); Thu, 7 Oct 2021 18:34:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:32315 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241497AbhJGWee (ORCPT ); Thu, 7 Oct 2021 18:34:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633645960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:in-reply-to:in-reply-to:references:references; bh=qB8O/AxLxFhDos55i0zRL7BIqJtlqTpIhhJqS56NxPs=; b=ShTeoWMKB4jeT+JCSnfMrhyHKkW7rL8huSkV1H/x9KmiBDjVNZhvXisCddFQng3LoP12fM VYEufjQp0ghAVKZ9As6pulejmtFbdej/MVauLx761OX4tK+rfM5CKuJJWVwz0fIv+w+UHD srG+bulO9aFeBAJWAFi02dIQzRil/Ho= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-4-zkqeEeuCPGyO-xs3OyB0Hg-1; Thu, 07 Oct 2021 18:30:49 -0400 X-MC-Unique: zkqeEeuCPGyO-xs3OyB0Hg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5055110A8E02; Thu, 7 Oct 2021 22:30:48 +0000 (UTC) Received: from dwysocha.rdu.csb (unknown [10.22.8.139]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B26BE5D9C6; Thu, 7 Oct 2021 22:30:47 +0000 (UTC) From: Dave Wysochanski To: Trond Myklebust , Anna Schumaker , David Howells Cc: linux-cachefs@redhat.com, linux-nfs@vger.kernel.org Subject: [PATCH v2 6/7] NFS: Remove remaining dfprintks related to fscache cookies Date: Thu, 7 Oct 2021 18:30:22 -0400 Message-Id: <1633645823-31235-7-git-send-email-dwysocha@redhat.com> In-Reply-To: <1633645823-31235-1-git-send-email-dwysocha@redhat.com> References: <1633645823-31235-1-git-send-email-dwysocha@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org The fscache cookie APIs including fscache_acquire_cookie() and fscache_relinquish_cookie() now have very good tracing. Thus, there is no real need for dfprintks in the NFS fscache interface. Signed-off-by: Dave Wysochanski --- fs/nfs/fscache.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/fs/nfs/fscache.c b/fs/nfs/fscache.c index 7dbe3a404f34..06c4d8ee7281 100644 --- a/fs/nfs/fscache.c +++ b/fs/nfs/fscache.c @@ -21,7 +21,7 @@ #include "fscache.h" #include "nfstrace.h" -#define NFSDBG_FACILITY NFSDBG_FSCACHE +#define NFSDBG_FACILITY NFSDBG_FSCACHE static struct rb_root nfs_fscache_keys = RB_ROOT; static DEFINE_SPINLOCK(nfs_fscache_keys_lock); @@ -86,8 +86,6 @@ void nfs_fscache_get_client_cookie(struct nfs_client *clp) &key, len, NULL, 0, clp, 0, true); - dfprintk(FSCACHE, "NFS: get client cookie (0x%p/0x%p)\n", - clp, clp->fscache); } /* @@ -95,9 +93,6 @@ void nfs_fscache_get_client_cookie(struct nfs_client *clp) */ void nfs_fscache_release_client_cookie(struct nfs_client *clp) { - dfprintk(FSCACHE, "NFS: releasing client cookie (0x%p/0x%p)\n", - clp, clp->fscache); - fscache_relinquish_cookie(clp->fscache, NULL, false); clp->fscache = NULL; } @@ -191,8 +186,6 @@ void nfs_fscache_get_super_cookie(struct super_block *sb, const char *uniq, int sizeof(key->key) + ulen, NULL, 0, nfss, 0, true); - dfprintk(FSCACHE, "NFS: get superblock cookie (0x%p/0x%p)\n", - nfss, nfss->fscache); return; non_unique: @@ -211,9 +204,6 @@ void nfs_fscache_release_super_cookie(struct super_block *sb) { struct nfs_server *nfss = NFS_SB(sb); - dfprintk(FSCACHE, "NFS: releasing superblock cookie (0x%p/0x%p)\n", - nfss, nfss->fscache); - fscache_relinquish_cookie(nfss->fscache, NULL, false); nfss->fscache = NULL; @@ -270,8 +260,6 @@ void nfs_fscache_clear_inode(struct inode *inode) struct nfs_inode *nfsi = NFS_I(inode); struct fscache_cookie *cookie = nfs_i_fscache(inode); - dfprintk(FSCACHE, "NFS: clear cookie (0x%p/0x%p)\n", nfsi, cookie); - nfs_fscache_update_auxdata(&auxdata, inode); fscache_relinquish_cookie(cookie, &auxdata, false); nfsi->fscache = NULL;