From patchwork Thu Jul 19 06:46:02 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: NeilBrown X-Patchwork-Id: 1215631 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 06311E006E for ; Thu, 19 Jul 2012 06:46:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753318Ab2GSGqC (ORCPT ); Thu, 19 Jul 2012 02:46:02 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46734 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753260Ab2GSGqA (ORCPT ); Thu, 19 Jul 2012 02:46:00 -0400 Received: from relay2.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 1486C99430; Thu, 19 Jul 2012 08:46:00 +0200 (CEST) Date: Thu, 19 Jul 2012 16:46:02 +1000 From: NeilBrown To: Trond Myklebust Cc: NFS Subject: NFSv4 callback: too many open connections, consider increasing the number of threads. Message-ID: <20120719164602.7d5aadaf@notabene.brown> X-Mailer: Claws Mail 3.7.10 (GTK+ 2.24.7; x86_64-suse-linux-gnu) Mime-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org [resending - with more current address for trond] Hi Trond et al. we have a customer who reports getting the message: [10879512.275305] NFSv4 callback: too many open connections, consider increasing the number of threads. [10879512.275315] NFSv4 callback: too many open connections, consider increasing the number of threads. [10879517.276133] __ratelimit: 133011 callbacks suppressed Of course you cannot increase the number of threads handling callbacks. The patch below will get rid of the message - which is presumably mostly just noise - or possibly change it to NFSv4 callback: too many open connections, consider increasing the max number of connections if the number of connections gets too high. This isn't much good as this patch doesn't allow the max number to be increased. Do we want to make the max number of callback connections configurable, or should we find a way to silence that message. (For lockd that message is valid as there is a sysctl to change the max number of connections for lockd). Thanks, NeilBrown diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c index 23ff18f..1129c42 100644 --- a/fs/nfs/callback.c +++ b/fs/nfs/callback.c @@ -265,6 +265,10 @@ int nfs_callback_up(u32 minorversion, struct rpc_xprt *xprt) ret = -ENOMEM; goto out_err; } + /* As there is only one thread so we need to over-ride the + * default maximum of 80 connections + */ + serv->sv_maxconn = 1024; ret = svc_bind(serv, net); if (ret < 0) {