From patchwork Tue Jul 31 17:11:21 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "J. Bruce Fields" X-Patchwork-Id: 1261221 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 7902BDF26F for ; Tue, 31 Jul 2012 17:11:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754166Ab2GaRLX (ORCPT ); Tue, 31 Jul 2012 13:11:23 -0400 Received: from fieldses.org ([174.143.236.118]:55511 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754122Ab2GaRLX (ORCPT ); Tue, 31 Jul 2012 13:11:23 -0400 Received: from bfields by fieldses.org with local (Exim 4.72) (envelope-from ) id 1SwFyc-0007qF-25; Tue, 31 Jul 2012 13:11:22 -0400 Date: Tue, 31 Jul 2012 13:11:21 -0400 From: "J. Bruce Fields" To: "Myklebust, Trond" Cc: David Howells , "Schumaker, Bryan" , "sct@redhat.com" , "linux-nfs@vger.kernel.org" , "steved@redhat.com" , "jlayton@redhat.com" Subject: Re: [PATCH 1/2] NFS: Fix a number of bugs in the idmapper Message-ID: <20120731171121.GF27834@fieldses.org> References: <1343746117.5528.3.camel@lade.trondhjem.org> <20120731144234.6664.85664.stgit@warthog.procyon.org.uk> <6978.1343746575@warthog.procyon.org.uk> <1343747261.5528.10.camel@lade.trondhjem.org> <20120731163708.GE27834@fieldses.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120731163708.GE27834@fieldses.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Tue, Jul 31, 2012 at 12:37:08PM -0400, bfields wrote: > On Tue, Jul 31, 2012 at 03:07:42PM +0000, Myklebust, Trond wrote: > > We don't expect people to be running both types of idmapper at the same > > time. Normally, the distribution will set up one or the other. However > > if both idmappers do happen to be configured, then we want to always > > choose the non-legacy type... > > On a quick check.... It looks like F17 has /usr/sbin/nfsidmap, and also > runs rpc.idmapd for the server. While rpc.idmap does have a "-S" > option, it's not using that. > > But that should be easy to fix--I'll go look.... Steve, this, or do we want to modify the default value of RPCIDMAPDARGS in nfs.sysconfig? --b. --- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/nfs-idmap.service b/nfs-idmap.service index 872ae09..93c1b3a 100644 --- a/nfs-idmap.service +++ b/nfs-idmap.service @@ -7,7 +7,7 @@ After=nfs-server.service Type=forking StandardError=syslog+console EnvironmentFile=-/etc/sysconfig/nfs -ExecStart=/usr/sbin/rpc.idmapd $RPCIDMAPDARGS +ExecStart=/usr/sbin/rpc.idmapd -S $RPCIDMAPDARGS [Install] WantedBy=nfs.target diff --git a/nfs.sysconfig b/nfs.sysconfig index 2d33cf3..4baa0c3 100644 --- a/nfs.sysconfig +++ b/nfs.sysconfig @@ -24,7 +24,7 @@ RPCMOUNTDOPTS="" STATDARG="" # # Optional arguments passed to rpc.idmapd. See rpc.idmapd(8) -RPCIDMAPDARGS="" +RPCIDMAPDARGS="-S" # # Optional arguments passed to rpc.gssd. See rpc.gssd(8) RPCGSSDARGS=""