From patchwork Mon Oct 22 16:06:04 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 1626721 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id CCDB4DFB79 for ; Mon, 22 Oct 2012 16:06:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755439Ab2JVQGI (ORCPT ); Mon, 22 Oct 2012 12:06:08 -0400 Received: from mail-ie0-f174.google.com ([209.85.223.174]:60605 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755157Ab2JVQGI (ORCPT ); Mon, 22 Oct 2012 12:06:08 -0400 Received: by mail-ie0-f174.google.com with SMTP id k13so3828544iea.19 for ; Mon, 22 Oct 2012 09:06:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:subject:to:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-type:content-transfer-encoding; bh=y6biKdk6ZP4kd/pTMe6Y9DO8kf/qkNRKX2olLjH+6Xc=; b=soa38VOqWR8Oaw5sv54Arm+t7XzlfDgmWrJBkfbv2tJosXVYXR01WcmqAh45yRCIHz 9LWr23Minuuxtm49puun/EcMFg8DRuxKOOWTfuB85kkeQgCnq90a2SuVDH+6xsFx8ZCu H3MuNlsNOISpQ38Lbb734R7ymuzJNJpountV9F5wyA43xMOTTFHt5F+C2nHaAxrTl/LY ggvMpGpX6WVk2pMUimnLXK5og3B3OkcEEdudmo1uCxu6rQmOFiJZnGJYK2ZtXRwi35Jv 9aXEPi9RqFj9bldtRGBJwnEEYsUlq/enSHH8bf+LhwxBHq112TUduwu9GoATBL0Bzbg/ Xcvw== Received: by 10.50.150.175 with SMTP id uj15mr16701019igb.52.1350921967882; Mon, 22 Oct 2012 09:06:07 -0700 (PDT) Received: from lebasque.1015granger.net (adsl-99-26-161-222.dsl.sfldmi.sbcglobal.net. [99.26.161.222]) by mx.google.com with ESMTPS id 7sm5773334igh.0.2012.10.22.09.06.04 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 22 Oct 2012 09:06:05 -0700 (PDT) From: Chuck Lever Subject: [PATCH 03/10] mountd: Eliminate unnecessary type conversions To: steved@redhat.com Cc: linux-nfs@vger.kernel.org Date: Mon, 22 Oct 2012 12:06:04 -0400 Message-ID: <20121022160604.4552.21104.stgit@lebasque.1015granger.net> In-Reply-To: <20121022160140.4552.34477.stgit@lebasque.1015granger.net> References: <20121022160140.4552.34477.stgit@lebasque.1015granger.net> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Clean up compiler warnings: cache.c:332:16: warning: conversion to ‘int’ from ‘size_t’ may alter its value [-Wconversion] cache.c:339:9: warning: conversion to ‘size_t’ from ‘int’ may change the sign of the result [-Wsign-conversion] cache.c: In function ‘subexport’: cache.c:354:17: warning: conversion to ‘int’ from ‘size_t’ may alter its value [-Wconversion] cache.c:357:9: warning: conversion to ‘size_t’ from ‘int’ may change the sign of the result [-Wsign-conversion] Seen with gcc version 4.6.3 20120306 (Red Hat 4.6.3-2) (GCC) . Signed-off-by: Chuck Lever --- utils/mountd/cache.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c index 6de05f1..70e1aa4 100644 --- a/utils/mountd/cache.c +++ b/utils/mountd/cache.c @@ -329,7 +329,7 @@ static char *next_mnt(void **v, char *p) { FILE *f; struct mntent *me; - int l = strlen(p); + size_t l = strlen(p); if (*v == NULL) { f = setmntent("/etc/mtab", "r"); *v = f; @@ -351,7 +351,7 @@ static char *next_mnt(void **v, char *p) static bool subexport(struct exportent *e1, struct exportent *e2) { char *p1 = e1->e_path, *p2 = e2->e_path; - int l2 = strlen(p2); + size_t l2 = strlen(p2); return e2->e_flags & NFSEXP_CROSSMOUNT && strncmp(p1, p2, l2) == 0