From patchwork Mon Oct 22 16:06:44 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 1626771 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id AA793DFB7A for ; Mon, 22 Oct 2012 16:06:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755555Ab2JVQGq (ORCPT ); Mon, 22 Oct 2012 12:06:46 -0400 Received: from mail-ia0-f174.google.com ([209.85.210.174]:59378 "EHLO mail-ia0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755440Ab2JVQGp (ORCPT ); Mon, 22 Oct 2012 12:06:45 -0400 Received: by mail-ia0-f174.google.com with SMTP id y32so2175418iag.19 for ; Mon, 22 Oct 2012 09:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:subject:to:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-type:content-transfer-encoding; bh=bF0m9S9TjZ5FFdhbXqZYzfm+JlAOfv7R1/0fA6e6stc=; b=BFwU3PlkzVAZ2RjTo7lmhzkgi0qocbS6Y+L9F6lCe3Wf8ewj0IGoCItXrdpNsIaprW q4/3auueaD1FtCSaH9hQ3xYpafQYg98WU2HkGPEerVk2ZH0kf1eM74mCcPQ1Gjche6j5 +hWeWYZKeOoIGsSVQ+R1tQD/96WkL7GL9RtIdLziJNDNZd8TB3bL1UeAO79p42zDa9qP MExE/fOSFPmaWB3Ss7TXPJ1HfpDxylIanA6jJeyiTt7fKo/ZKCIoE71YVXN1BpKXOCBE vFxdFyQ08VrMyFKKbRlRUm4cHdvwFRj5TN39LXPrnZec5JxYMLcfODcApgTwF9t5zxyC FDew== Received: by 10.50.51.194 with SMTP id m2mr9622016igo.53.1350922005558; Mon, 22 Oct 2012 09:06:45 -0700 (PDT) Received: from lebasque.1015granger.net (adsl-99-26-161-222.dsl.sfldmi.sbcglobal.net. [99.26.161.222]) by mx.google.com with ESMTPS id x5sm13553713igc.14.2012.10.22.09.06.44 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 22 Oct 2012 09:06:45 -0700 (PDT) From: Chuck Lever Subject: [PATCH 07/10] mountd: Avoid unnecessary type conversions To: steved@redhat.com Cc: linux-nfs@vger.kernel.org Date: Mon, 22 Oct 2012 12:06:44 -0400 Message-ID: <20121022160644.4552.477.stgit@lebasque.1015granger.net> In-Reply-To: <20121022160140.4552.34477.stgit@lebasque.1015granger.net> References: <20121022160140.4552.34477.stgit@lebasque.1015granger.net> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Clean up compiler warnings: cache.c: In function ‘get_uuid’: cache.c:256:17: warning: conversion to ‘char’ from ‘int’ may alter its value [-Wconversion] cache.c:258:17: warning: conversion to ‘char’ from ‘int’ may alter its value [-Wconversion] cache.c:260:16: warning: conversion to ‘char’ from ‘int’ may alter its value [-Wconversion] cache.c:262:6: warning: conversion to ‘char’ from ‘int’ may alter its value [-Wconversion] Seen with gcc version 4.6.3 20120306 (Red Hat 4.6.3-2) (GCC) Signed-off-by: Chuck Lever --- utils/mountd/cache.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c index fbaa28e..e950ec6 100644 --- a/utils/mountd/cache.c +++ b/utils/mountd/cache.c @@ -248,7 +248,7 @@ static int get_uuid(const char *val, size_t uuidlen, char *u) memset(u, 0, uuidlen); for ( ; *val ; val++) { - char c = *val; + int c = *val; if (!isxdigit(c)) continue; if (isalpha(c)) { @@ -260,7 +260,7 @@ static int get_uuid(const char *val, size_t uuidlen, char *u) c = c - '0' + 0; if ((i&1) == 0) c <<= 4; - u[i/2] ^= c; + u[i/2] ^= (char)c; i++; if (i == uuidlen*2) i = 0;