From patchwork Fri Feb 8 21:28:13 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 2118771 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id DD1F7E00C6 for ; Fri, 8 Feb 2013 21:28:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1947086Ab3BHV2Q (ORCPT ); Fri, 8 Feb 2013 16:28:16 -0500 Received: from mail-ia0-f172.google.com ([209.85.210.172]:54176 "EHLO mail-ia0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1947216Ab3BHV2P (ORCPT ); Fri, 8 Feb 2013 16:28:15 -0500 Received: by mail-ia0-f172.google.com with SMTP id u8so4762830iag.3 for ; Fri, 08 Feb 2013 13:28:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:subject:to:cc:date:message-id:in-reply-to :references:user-agent:mime-version:content-type :content-transfer-encoding; bh=ZqS/e3e+qbGXF/etPMcvnVFHNLsan5tISgtW3QVsKSA=; b=STTrZ4bb0Q+iqeGPPx+qhc/hA/zunEMqUQnNx7Av3izwnyASv+wvCFKFkqrrUCsO/e Rvs8B7EJnGwBSGWCif23A0073/qqD5gW0i6rOnNAzVLqH2ZfJPCOiRcRAj3uvec2Xp8a qZtOhbvK5WakkTkHkBUQQDbGta7MXyxrQcdlVixZKlnudFSuUA41ikRzJJOccDxSWyHu tnw6xSlJoBBQ4CEB9KwgfnYHzWu8fB6bZxnE9lMb5XA0JW4fJiMRiiJC/azAq6Hyuwjr O/3F2zq0v7OOkNqzKZo07hFbl9xcPt82LAfuaIoIoKFo1Wjy4Nh+Rq/q63UiUL5IaLqo vHHg== X-Received: by 10.42.19.197 with SMTP id d5mr11502588icb.29.1360358894613; Fri, 08 Feb 2013 13:28:14 -0800 (PST) Received: from seurat.1015granger.net (adsl-99-26-161-222.dsl.sfldmi.sbcglobal.net. [99.26.161.222]) by mx.google.com with ESMTPS id ig8sm16975188igc.10.2013.02.08.13.28.13 (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 08 Feb 2013 13:28:14 -0800 (PST) From: Chuck Lever Subject: [PATCH v1 3/3] NFSD: Kill some mixed sign comparisons in fs/nfsd/nfs4xdr.c To: linux-nfs@vger.kernel.org Cc: Chuck Lever Date: Fri, 08 Feb 2013 16:28:13 -0500 Message-ID: <20130208212812.2234.76113.stgit@seurat.1015granger.net> In-Reply-To: <20130208212007.2234.35721.stgit@seurat.1015granger.net> References: <20130208212007.2234.35721.stgit@seurat.1015granger.net> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Clean up. Signed-off-by: Chuck Lever --- fs/nfsd/nfs4xdr.c | 9 ++++----- fs/nfsd/xdr4.h | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c index 4e9f0b5..165f6f4 100644 --- a/fs/nfsd/nfs4xdr.c +++ b/fs/nfsd/nfs4xdr.c @@ -244,7 +244,7 @@ static __be32 nfsd4_decode_fattr(struct nfsd4_compoundargs *argp, u32 *bmval, struct iattr *iattr, struct nfs4_acl **acl) { - int expected_len, len = 0; + u32 expected_len, len = 0; u32 dummy32; char *buf; int host_err; @@ -1125,8 +1125,7 @@ nfsd4_decode_verify(struct nfsd4_compoundargs *argp, struct nfsd4_verify *verify static __be32 nfsd4_decode_write(struct nfsd4_compoundargs *argp, struct nfsd4_write *write) { - int avail; - int len; + u32 avail, len; DECODE_HEAD; status = nfsd4_decode_stateid(argp, &write->wr_stateid); @@ -1193,7 +1192,7 @@ static __be32 nfsd4_decode_exchange_id(struct nfsd4_compoundargs *argp, struct nfsd4_exchange_id *exid) { - int dummy, tmp; + u32 dummy, tmp; DECODE_HEAD; READ_BUF(NFS4_VERIFIER_SIZE); @@ -3022,7 +3021,7 @@ nfsd4_encode_readlink(struct nfsd4_compoundres *resp, __be32 nfserr, struct nfsd static __be32 nfsd4_encode_readdir(struct nfsd4_compoundres *resp, __be32 nfserr, struct nfsd4_readdir *readdir) { - int maxcount; + unsigned int maxcount; loff_t offset; __be32 *page, *savep, *tailbase; __be32 *p; diff --git a/fs/nfsd/xdr4.h b/fs/nfsd/xdr4.h index 0889bfb..e2ebd9b 100644 --- a/fs/nfsd/xdr4.h +++ b/fs/nfsd/xdr4.h @@ -482,7 +482,7 @@ struct nfsd4_compoundargs { __be32 * p; __be32 * end; struct page ** pagelist; - int pagelen; + unsigned int pagelen; __be32 tmp[8]; __be32 * tmpp; struct tmpbuf {