| Message ID | 20130603010021.20080.24416.stgit@notabene.brown (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/06/13 21:00, Neil Brown wrote: > When initialising an array there is no need to specify the size as the > size is taken from the initialiser. Having the size there means that > any change to the initialiser needs to change the size to and so is > error-prone. > > So just remove the size. Committed.... steved. > > Signed-off-by: NeilBrown <neilb@suse.de> > --- > utils/gssd/krb5_util.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/utils/gssd/krb5_util.c b/utils/gssd/krb5_util.c > index 6275dd8..9ef80f0 100644 > --- a/utils/gssd/krb5_util.c > +++ b/utils/gssd/krb5_util.c > @@ -1236,7 +1236,7 @@ gssd_refresh_krb5_machine_credential(char *hostname, > krb5_keytab kt = NULL;; > int retval = 0; > char *k5err = NULL; > - const char *svcnames[5] = { "$", "root", "nfs", "host", NULL }; > + const char *svcnames[] = { "$", "root", "nfs", "host", NULL }; > > /* > * If a specific service name was specified, use it. > > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/utils/gssd/krb5_util.c b/utils/gssd/krb5_util.c index 6275dd8..9ef80f0 100644 --- a/utils/gssd/krb5_util.c +++ b/utils/gssd/krb5_util.c @@ -1236,7 +1236,7 @@ gssd_refresh_krb5_machine_credential(char *hostname, krb5_keytab kt = NULL;; int retval = 0; char *k5err = NULL; - const char *svcnames[5] = { "$", "root", "nfs", "host", NULL }; + const char *svcnames[] = { "$", "root", "nfs", "host", NULL }; /* * If a specific service name was specified, use it.
When initialising an array there is no need to specify the size as the size is taken from the initialiser. Having the size there means that any change to the initialiser needs to change the size to and so is error-prone. So just remove the size. Signed-off-by: NeilBrown <neilb@suse.de> --- utils/gssd/krb5_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html