| Message ID | 20151105083708.GA19405@mwanda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> On Nov 5, 2015, at 3:37 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > > It doesn't matter either way, but the curly braces were clearly intended > here. It causes a Smatch warning. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Chuck Lever <chuck.lever@oracle.com> > diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c > index eadd1655..2cc1014 100644 > --- a/net/sunrpc/xprtrdma/verbs.c > +++ b/net/sunrpc/xprtrdma/verbs.c > @@ -852,10 +852,11 @@ retry: > > if (extras) { > rc = rpcrdma_ep_post_extra_recv(r_xprt, extras); > - if (rc) > + if (rc) { > pr_warn("%s: rpcrdma_ep_post_extra_recv: %i\n", > __func__, rc); > rc = 0; > + } > } > } > — Chuck Lever -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c index eadd1655..2cc1014 100644 --- a/net/sunrpc/xprtrdma/verbs.c +++ b/net/sunrpc/xprtrdma/verbs.c @@ -852,10 +852,11 @@ retry: if (extras) { rc = rpcrdma_ep_post_extra_recv(r_xprt, extras); - if (rc) + if (rc) { pr_warn("%s: rpcrdma_ep_post_extra_recv: %i\n", __func__, rc); rc = 0; + } } }
It doesn't matter either way, but the curly braces were clearly intended here. It causes a Smatch warning. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html