From patchwork Tue Mar 29 14:02:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Al Viro X-Patchwork-Id: 8687441 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2AD44C0554 for ; Tue, 29 Mar 2016 14:02:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5FC6420212 for ; Tue, 29 Mar 2016 14:02:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D97B201C8 for ; Tue, 29 Mar 2016 14:02:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753063AbcC2OCs (ORCPT ); Tue, 29 Mar 2016 10:02:48 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:34701 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752158AbcC2OCs (ORCPT ); Tue, 29 Mar 2016 10:02:48 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.76 #1 (Red Hat Linux)) id 1akuEG-0002Q1-Kw; Tue, 29 Mar 2016 14:02:44 +0000 Date: Tue, 29 Mar 2016 15:02:44 +0100 From: Al Viro To: Arend Van Spriel Cc: Junichi Nomura , "linux-kernel@vger.kernel.org" , Linux NFS Mailing List Subject: Re: [REGRESSION 4.6-rc1] NFS mounts (using autofs) failing Message-ID: <20160329140244.GV17997@ZenIV.linux.org.uk> References: <56FA62FB.1080506@broadcom.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <56FA62FB.1080506@broadcom.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Mar 29, 2016 at 01:11:55PM +0200, Arend Van Spriel wrote: > Hi Al, > > Moved to 4.6-rc1 and found NFS mounts were failing moving to the new > kernel. The NFS mounts are done using autofs. Below is the bisect log > and attached the kernel .config file. Let me know if you need any other > information. AFAICS, it's the same one that got reported yesterday by Junichi Nomura. Folks, could you check if the delta below fixes it? Tested-by: Arend van Spriel Tested-by: Jun'ichi Nomura --- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/namei.c b/fs/namei.c index 3498d53..0d80c72 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -1740,15 +1740,17 @@ static int walk_component(struct nameidata *nd, int flags) nd->flags); if (IS_ERR(path.dentry)) return PTR_ERR(path.dentry); - if (unlikely(d_is_negative(path.dentry))) { - dput(path.dentry); - return -ENOENT; - } + path.mnt = nd->path.mnt; err = follow_managed(&path, nd); if (unlikely(err < 0)) return err; + if (unlikely(d_is_negative(path.dentry))) { + path_to_nameidata(&path, nd); + return -ENOENT; + } + seq = 0; /* we are already out of RCU mode */ inode = d_backing_inode(path.dentry); }