From patchwork Fri May 27 12:16:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "J. Bruce Fields" X-Patchwork-Id: 9138237 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0E69160759 for ; Fri, 27 May 2016 12:16:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 015FC28135 for ; Fri, 27 May 2016 12:16:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EA3AD2818B; Fri, 27 May 2016 12:16:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5AA3E28135 for ; Fri, 27 May 2016 12:16:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751533AbcE0MQg (ORCPT ); Fri, 27 May 2016 08:16:36 -0400 Received: from fieldses.org ([173.255.197.46]:33728 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751480AbcE0MQf (ORCPT ); Fri, 27 May 2016 08:16:35 -0400 Received: by fieldses.org (Postfix, from userid 2815) id E00402407; Fri, 27 May 2016 08:16:32 -0400 (EDT) Date: Fri, 27 May 2016 08:16:32 -0400 From: "J. Bruce Fields" To: George Spelvin Cc: linux@horizon.com, jlayton@poochiereds.net, linux-nfs@vger.kernel.org Subject: Re: [PATCH RESEND 03/10] : Define hash_str() in terms of hash_string() Message-ID: <20160527121632.GC25272@fieldses.org> References: <20160527015605.7083.qmail@ns.sciencehorizons.net> <20160527032946.12751.qmail@ns.sciencehorizons.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160527032946.12751.qmail@ns.sciencehorizons.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, May 26, 2016 at 11:29:46PM -0400, George Spelvin wrote: > Okay, it's now okay to re-pull. I renamed mine to hashlen_string(), > since that's what it returns (the hash and the length), which both > solves the problem,and is frankly a better name. > > Thank you for prodding me to wade through the GCC 6 warning > spam. Thre were some problems hiding there. > > I discovered that adding #include breaks the tools.perf > build. It makes local copies of some kernel headers under control of > a MANIFEST file, and I can't be arsed to figure it out. > > So I deleted the BUILD_BUG_ON entirely, and it's now (finally!) finished > an allyesconfig build without any warnings that look new. I also needed the following. That still gets me some compiler warnings in gfs2, but looks like code your patches don't touch, so that's probably a preexisting gfs2 problem. But... the resulting kernel isn't booting succesfully for me. Not sure what's up there, I'll investigate some more. --b. commit 5168cb717b37ef0b183dee9b411a85831b558b9b Author: J. Bruce Fields Date: Fri May 27 07:10:21 2016 -0400 XXX --- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/linux/hash.h b/include/linux/hash.h index 1afde47..21b8ebc 100644 --- a/include/linux/hash.h +++ b/include/linux/hash.h @@ -15,6 +15,7 @@ */ #include +#include #include /* 2^31 + 2^29 - 2^25 + 2^22 - 2^19 - 2^16 + 1 */