From patchwork Wed Nov 9 20:23:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "J. Bruce Fields" X-Patchwork-Id: 9420129 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 955786048E for ; Wed, 9 Nov 2016 20:24:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 89DA6286B2 for ; Wed, 9 Nov 2016 20:24:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7A91B293E7; Wed, 9 Nov 2016 20:24:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 10F1D286B2 for ; Wed, 9 Nov 2016 20:24:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753926AbcKIUYB (ORCPT ); Wed, 9 Nov 2016 15:24:01 -0500 Received: from fieldses.org ([173.255.197.46]:39718 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751677AbcKIUYB (ORCPT ); Wed, 9 Nov 2016 15:24:01 -0500 Received: by fieldses.org (Postfix, from userid 2815) id 3E8874C6A; Wed, 9 Nov 2016 15:23:59 -0500 (EST) Date: Wed, 9 Nov 2016 15:23:59 -0500 From: "J. Bruce Fields" To: Jeff Layton Cc: Tejun Heo , Bhaktipriya Shridhar , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue Message-ID: <20161109202359.GC4952@fieldses.org> References: <20160830205348.GA31915@Karyakshetra> <20161108213911.GA27681@fieldses.org> <20161108225221.GB6460@htj.duckdns.org> <20161109012725.GA29930@fieldses.org> <1478697488.7930.7.camel@poochiereds.net> <20161109162752.GA4952@fieldses.org> <1478712815.7930.28.camel@poochiereds.net> <20161109194724.GB4952@fieldses.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20161109194724.GB4952@fieldses.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Nov 09, 2016 at 02:47:24PM -0500, J. Bruce Fields wrote: > For now I wish we could just like to continue assuming the workqueue > processes only one item at a time. Do we have that now, or do we need > to switch to (looking at workqueue.h...) alloc_ordered workqueue()? Oh, wait, I missed the _ordered_ in: #define create_singlethread_workqueue(name) \ alloc_ordered_workqueue("%s", __WQ_LEGACY | WQ_MEM_RECLAIM, name) So our existing create_singlethread_workqueue is fine--but we probably don't need those flags: --b. --- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c index 211dc2aed8e1..eb78109d666c 100644 --- a/fs/nfsd/nfs4callback.c +++ b/fs/nfsd/nfs4callback.c @@ -1061,7 +1061,7 @@ static const struct rpc_call_ops nfsd4_cb_ops = { int nfsd4_create_callback_queue(void) { - callback_wq = create_singlethread_workqueue("nfsd4_callbacks"); + callback_wq = alloc_ordered_workqueue("nfsd4_callbacks", 0); if (!callback_wq) return -ENOMEM; return 0;