From patchwork Thu Nov 10 16:44:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9421521 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CDE4E60721 for ; Thu, 10 Nov 2016 16:48:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CFD1629504 for ; Thu, 10 Nov 2016 16:48:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C3BBD29778; Thu, 10 Nov 2016 16:48:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 75BBC29504 for ; Thu, 10 Nov 2016 16:48:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964904AbcKJQrx (ORCPT ); Thu, 10 Nov 2016 11:47:53 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:59362 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964887AbcKJQru (ORCPT ); Thu, 10 Nov 2016 11:47:50 -0500 Received: from wuerfel.lan ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0M48SR-1cwR0O1239-00rnk4; Thu, 10 Nov 2016 17:45:43 +0100 From: Arnd Bergmann To: Linus Torvalds Cc: Andrew Morton , Arnd Bergmann , Anna Schumaker , "David S. Miller" , Herbert Xu , Ilya Dryomov , Javier Martinez Canillas , Jiri Kosina , Jonathan Cameron , Ley Foon Tan , "Luis R . Rodriguez" , Martin Schwidefsky , Mauro Carvalho Chehab , Michal Marek , Russell King , Sean Young , Sebastian Ott , Trond Myklebust , x86@kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, nios2-dev@lists.rocketboards.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, linux-media@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v2 07/11] [media] rc: print correct variable for z8f0811 Date: Thu, 10 Nov 2016 17:44:50 +0100 Message-Id: <20161110164454.293477-8-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20161110164454.293477-1-arnd@arndb.de> References: <20161110164454.293477-1-arnd@arndb.de> X-Provags-ID: V03:K0:I48EU70rNIIJauXLBOhPboRKL2oZVbv2PJs72dsP8yWyN+wBhQv MI4JMVkDjTOF9Qm6SPs3r2RHCUFCykxYDoWNWi+lK3g6VRz5N2/vISpkE8nOLAjZBD067wH 6p3ixXhzahFK1to+3rPA4AUqD2FL819COuIUal8ikpVCKO+WCv7ZhwhcEqwbic/6rrbUH2E 8/v0U86G+VLhn0E3Z/FrQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:XwQ2ynZpHdk=:tyxlLM3dM8D/BbbwuU6dfE /RUfqMQCQY09fiP+wgxOt85IPSv3NDhPXPtoPCDz4tAusOImfQvKKywJ0XfAZ06fymjlXnEib yyEZB+vTPM3W2Rs44emQQ9bmmoUVuT4r7HpsSc+SKGxz66BX8QF+2kOz+Rt7g+HKVOS9zjM8R J0hjO46c5DLHBp+MDJeUaHUKnc4Me9HiRycmL2aeWWgdOnlX+QYB1ihCCjMTjXNH3CZmxS5MW LXsFdzr/INbgTR5ScCpyhrR/qemBgdkT1EejWKhxlUZZvAgJ3pkLgfe0kJYh63ZvyuDtHLkSI nGr8bqJSQnJhtZYFxvx73gputt0OUQWHnyKfZNq5W46Mgp/+uFRYdUxsPdvFqJ33LlRfmCAsR jYc+AZqqh8LekAujjus/Qp2bFs8U4ObHRUfJUqVoqTRUIe0Js3NehkeoxxYNOUILSqqhbOEbw 97rWXUhEMxlWqjoLijuWm6XaQHXm3OP3ySONhkS+rzpFuyk6RXAKk608+NX3s7AiyyFtAlMUD 4C0B6IrJSls5YsjVdyaCVdDXCulNbeK6W2zEnks3c01IlLa6X8LCiSo8p7YKwhOlZHdWd+XSc xcDWpyFO7UF0gbNQQNq0fqPT59ueVeeb6Hq3lHPzkkaU4+XVrZTozVImEh5fJ0gkg0g7Dcgmb q8HdeQj/fgUFHL3H0TmkvfoQJvWvMVq9i6RixG8MHe+iHF+rQluc/lDFPKWpMzZ1UyX8= Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A recent rework accidentally left a debugging printk untouched while changing the meaning of the variables, leading to an uninitialized variable being printed: drivers/media/i2c/ir-kbd-i2c.c: In function 'get_key_haup_common': drivers/media/i2c/ir-kbd-i2c.c:62:2: error: 'toggle' may be used uninitialized in this function [-Werror=maybe-uninitialized] This prints the correct one instead, as we did before the patch. Fixes: 00bb820755ed ("[media] rc: Hauppauge z8f0811 can decode RC6") Signed-off-by: Arnd Bergmann --- drivers/media/i2c/ir-kbd-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) I submitted this repeatedly as it is a v4.9 regression, but I never saw a reply for it. diff --git a/drivers/media/i2c/ir-kbd-i2c.c b/drivers/media/i2c/ir-kbd-i2c.c index f95a6bc..cede397 100644 --- a/drivers/media/i2c/ir-kbd-i2c.c +++ b/drivers/media/i2c/ir-kbd-i2c.c @@ -118,7 +118,7 @@ static int get_key_haup_common(struct IR_i2c *ir, enum rc_type *protocol, *protocol = RC_TYPE_RC6_MCE; dev &= 0x7f; dprintk(1, "ir hauppauge (rc6-mce): t%d vendor=%d dev=%d code=%d\n", - toggle, vendor, dev, code); + *ptoggle, vendor, dev, code); } else { *ptoggle = 0; *protocol = RC_TYPE_RC6_6A_32;