[xfstests] dirstress: Allow ESTALE as well as ENOENT

Commit Message

J. Bruce Fields Nov. 25, 2016, 3:47 a.m. UTC

On Wed, Nov 23, 2016 at 04:19:11PM -0700, Andreas Dilger wrote:
> On Nov 23, 2016, at 3:20 PM, J. Bruce Fields <[e-mail]> wrote:
> > 
> > From: "J. Bruce Fields" <[e-mail]>
> > 
> > In the NFS case an attempt to chdir out of a removed directory could result
> > in ESTALE, and that should not cause the test to fail.
> > 
> > This was causing intermittent failures on generic/011 on NFS.
> > 
> > Signed-off-by: J. Bruce Fields <[e-mail]>
> > ---
> > src/dirstress.c | 12 ++++++++----
> > 1 file changed, 8 insertions(+), 4 deletions(-)
> > 
> > Sorry, who do xfstests patches go to?--b.
> 
> They are sent to [e-mail]

Thanks!

Might be worth something like this too?

--b.

commit 0d61e7b9779d
Author: J. Bruce Fields <[e-mail]>
Date:   Thu Nov 24 22:41:26 2016 -0500

    Document fstests mailing list
    
    Signed-off-by: J. Bruce Fields <[e-mail]>

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Eryu Guan Nov. 25, 2016, 11:35 a.m. UTC | #1

Hi Bruce,

On Thu, Nov 24, 2016 at 10:47:06PM -0500, J. Bruce Fields wrote:
> On Wed, Nov 23, 2016 at 04:19:11PM -0700, Andreas Dilger wrote:
> > On Nov 23, 2016, at 3:20 PM, J. Bruce Fields <[e-mail]> wrote:
> > > 
> > > From: "J. Bruce Fields" <[e-mail]>
> > > 
> > > In the NFS case an attempt to chdir out of a removed directory could result
> > > in ESTALE, and that should not cause the test to fail.
> > > 
> > > This was causing intermittent failures on generic/011 on NFS.
> > > 
> > > Signed-off-by: J. Bruce Fields <[e-mail]>
> > > ---
> > > src/dirstress.c | 12 ++++++++----
> > > 1 file changed, 8 insertions(+), 4 deletions(-)
> > > 
> > > Sorry, who do xfstests patches go to?--b.
> > 
> > They are sent to [e-mail]
> 
> Thanks!
> 
> Might be worth something like this too?

This looks fine to me. Can you please resend as a formal patch? Also the
patch to fix dirstress.c.

Thanks,
Eryu
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/README b/README
index d1f6788a17a3..0a6ac6ece5aa 100644
--- a/README
+++ b/README
@@ -248,3 +248,9 @@  Pass/failure:
     The recent pass/fail history is maintained in the file "check.log".
     The elapsed time for the most recent pass for each test is kept
     in "check.time".
+
+__________________
+SUBMITTING PATCHES
+__________________
+
+Send patches to the fstests mailing list at [e-mail].