From patchwork Mon Nov 28 21:47:25 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "J. Bruce Fields" X-Patchwork-Id: 9450607 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CB6C86071C for ; Mon, 28 Nov 2016 21:47:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BDB9F27BFF for ; Mon, 28 Nov 2016 21:47:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B20C527F89; Mon, 28 Nov 2016 21:47:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C887127BFF for ; Mon, 28 Nov 2016 21:47:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755612AbcK1Vrx (ORCPT ); Mon, 28 Nov 2016 16:47:53 -0500 Received: from fieldses.org ([173.255.197.46]:35224 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755606AbcK1Vrx (ORCPT ); Mon, 28 Nov 2016 16:47:53 -0500 Received: by fieldses.org (Postfix, from userid 2815) id 7BD324A2F; Mon, 28 Nov 2016 16:47:25 -0500 (EST) Date: Mon, 28 Nov 2016 16:47:25 -0500 To: "J. Bruce Fields" Cc: Tom Haynes , Linux NFS Mailing list Subject: Re: [PATCH pynfs 00/12] Flex File support Message-ID: <20161128214725.GD30954@fieldses.org> References: <1480228001-64821-1-git-send-email-loghyr@primarydata.com> <20161128163321.GB30805@parsley.fieldses.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20161128163321.GB30805@parsley.fieldses.org> User-Agent: Mutt/1.5.21 (2010-09-15) From: bfields@fieldses.org (J. Bruce Fields) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Nov 28, 2016 at 11:33:21AM -0500, J. Bruce Fields wrote: > On Sat, Nov 26, 2016 at 10:26:29PM -0800, Tom Haynes wrote: > > I wanted to add client support for the flex file layout. > > > > Note, I did not add pynfs as a flag because I didn't want to > > mess up with any existing uses of it. > > > > The other major change here is in closing all opened > > files and destroying all clientids. With all the tests > > which run against my server, there are no longer any > > open files. There are however 11 clientids remaining. > > > > I will track those down. > > > > fwiw - these are in my staging branch at git://linux-nfs.org/~loghyr/pynfs.git > > Thanks! I'll try these and take a look. It breaks all the 4.0 tests: ACC3 st_access.testNoFh : FAILURE AttributeError: 'Environment' object has no attribute 'clean_clients' The problem is that nfs4.1/testmod.py is used by 4.0 as well, but there's not a 4.0 version of clean_clients.... Simplest I guess is to do as with clean_sessions and define a dummy method. --b. the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/nfs4.0/servertests/environment.py b/nfs4.0/servertests/environment.py index 6fe083a..221c3ed 100644 --- a/nfs4.0/servertests/environment.py +++ b/nfs4.0/servertests/environment.py @@ -229,6 +229,9 @@ class Environment(testmod.Environment): def clean_sessions(self): return + def clean_clients(self): + return + ######################################### debug_fail = False -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in