Message ID | 20170407181528.2832-21-Anna.Schumaker@Netapp.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-nfs-owner@kernel.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9173D60364 for <patchwork-linux-nfs@patchwork.kernel.org>; Fri, 7 Apr 2017 18:16:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8A6132862A for <patchwork-linux-nfs@patchwork.kernel.org>; Fri, 7 Apr 2017 18:16:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7F4C828635; Fri, 7 Apr 2017 18:16:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5AECA28634 for <patchwork-linux-nfs@patchwork.kernel.org>; Fri, 7 Apr 2017 18:16:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933619AbdDGSQQ (ORCPT <rfc822;patchwork-linux-nfs@patchwork.kernel.org>); Fri, 7 Apr 2017 14:16:16 -0400 Received: from mx141.netapp.com ([216.240.21.12]:41488 "EHLO mx141.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933820AbdDGSQD (ORCPT <rfc822;linux-nfs@vger.kernel.org>); Fri, 7 Apr 2017 14:16:03 -0400 X-IronPort-AV: E=Sophos;i="5.37,167,1488873600"; d="scan'208";a="194559150" Received: from hioexcmbx07-prd.hq.netapp.com ([10.122.105.40]) by mx141-out.netapp.com with ESMTP; 07 Apr 2017 11:04:29 -0700 Received: from VMWEXCCAS06-PRD.hq.netapp.com (10.122.105.22) by hioexcmbx07-prd.hq.netapp.com (10.122.105.40) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 7 Apr 2017 11:15:55 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (10.120.60.153) by VMWEXCCAS06-PRD.hq.netapp.com (10.122.105.22) with Microsoft SMTP Server (TLS) id 15.0.1210.3 via Frontend Transport; Fri, 7 Apr 2017 11:15:55 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netapp.onmicrosoft.com; s=selector1-netapp-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3QPd0YlSpGA5OwcK7xsaSr4JR3TqWcm20PJNDM2yTUo=; b=S7ihghqWgPisWELk2E6ylsXaa0QtL1e9abPQedZtGxRLYTvBpQMTkOdNirn0gjVW/7PG3fyabNpouGONcTH+JrclMtwz+x8Ut4Z7wb8xaTCHQYpqJmWlFNXgB2F7M5w6QyIfTDGsUSIm9e4+nNApMaLJyXPyFNtLXouyNhoy9PY= Authentication-Results: primarydata.com; dkim=none (message not signed) header.d=none; primarydata.com; dmarc=none action=none header.from=Netapp.com; Received: from gouda.nowheycreamery.com.nowheycreamery.com (68.40.188.1) by CY4PR06MB2472.namprd06.prod.outlook.com (10.169.186.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.17; Fri, 7 Apr 2017 18:15:54 +0000 From: <Anna.Schumaker@Netapp.com> To: <Trond.Myklebust@primarydata.com>, <linux-nfs@vger.kernel.org> Subject: [PATCH 20/34] NFS: Clean up nfs4_check_serverowner_major_id() Date: Fri, 7 Apr 2017 14:15:14 -0400 Message-ID: <20170407181528.2832-21-Anna.Schumaker@Netapp.com> X-Mailer: git-send-email 2.12.2 In-Reply-To: <20170407181528.2832-1-Anna.Schumaker@Netapp.com> References: <20170407181528.2832-1-Anna.Schumaker@Netapp.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [68.40.188.1] X-ClientProxiedBy: DM5PR20CA0021.namprd20.prod.outlook.com (10.173.136.159) To CY4PR06MB2472.namprd06.prod.outlook.com (10.169.186.140) X-MS-Office365-Filtering-Correlation-Id: 8066ebe4-904f-4227-2928-08d47de221cd X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:CY4PR06MB2472; X-Microsoft-Exchange-Diagnostics: 1; CY4PR06MB2472; 3:2yD9K/Y73xEqRR2hy1wxSj1E1/jBQrKr5Fi2QvpCPoEYSqQeCtxneBkxNyOieM/rle4RXyWrD+zU+WrSDuQagdmRTA8jRPr13jHMd2A60INLJxv3tBK3gTtoABpm8A3bk2wNMgJJOvZmNMFqYDxxIwmbXpyc9FvdV5rqLORyQEm/FyxTcuaCGcIG5AYp4G1JnG/icyu2GtMn4Bl+Ik1wXCwcXrZxA/Hp0rwp4/jeya9aCF8I1RUkaoZlaE+Mp21iZd48kYvSzUZi4BXEpYqzuZ4pU8gDfpJP/Z2RNZiKpUkacpkGni0f4Q2dHRpSyouGJD6bizsY6GCK7b+cUSwitg==; 25:ASu1pcMPvxP09Yj0mPPNGmuQQA9v+9u/YzqhmCx5dSZXJojpyEr4EtCqawTT3IzgHKWuA0RIOtU5fRTT4UTs1ENvSr9ts6PMGN9saWm/i8I7ApcrdJYPa7o/H3H/UO8MBNmDvrTsEtZBNGRZbmcZzkekV/FOB/EJXta/gOLhnvfnZS0xuyFzuVomcS5nZBRFt9+oc1ojNRNg9xc/P+1Tl+RjZV1kqHcs7Aul0olDd7ysKyjv/vHDT0TPQWT8posw9+FqzoXMpw6gsgFY/nFwjJA4hhVvO7RPHQrEhWwOFJ36L1ti5jwY+vH7904Gz2LN67wZCVQvyF6ugHR03M1GBkg0oInlYkINCNVxrB200qyfW6lSSU333vfnq3xHpJWWPSLoEeoxsONCrsWmPO3EwlqZ5GKHJcIGrZBBphSC38bpUK/fU1JJ1Y1voN/7hlrow5Dl+aSYe0mpWRx5Mo5R5g== X-Microsoft-Exchange-Diagnostics: 1; CY4PR06MB2472; 31:3iFPNYKR06JtapBZz5fs2qhdrTPlRHXHv3T8vHNSBlv3L3MUVxzorTNwmkBtP/GRhzjv1s0woPYgqGyMQhZc2ff+V5B0r1EZYInJa/lmnM7gYsZAbY4sRL3+THIbH0JnTq6klsQi+oZ0EeGNsDnxyWIdzvT1C9Rd/EcsN25ei5p1Rhw7b1qmhsgBZ+7EPDp+4+26bpRd6FfyIdLVDKd6K3/Qy0xd1PGU3scOzS03Ym9f66vZYIsVgfkham+YP0L5; 20:lhGhP0XQ/cPsf0wjpSidImqJIwRT3pufIKk3qG19KEMrNyrF9maG1Yzito5hTADkLateLd3PVBVl9crxnKdUV4fvCV8wm8Naw7bUJFNI5/aDF1WWuo9bcxVMDRsPVwtCxOx24eFchHKS998K0jRC+JkN64pqXpPaKGgBVXn5VeVsFZF/eaTIrERAV37AVRn9KhAz70ILbHJnEd2TShVR8skPl1arnewzwQj5ZqtTsP2A7UKA1+hhCDfil9poclho002qCYqLOWLOib+mn0L0T1xFMfC+fvpz9DVro1/1TMk7i/MVw0X5EAlNKVn4pzRX5W8emtlUd+G5mcMHSStQspCSIBi/5gYpniNFg55IRtmWPnyOE0gyjC5H5XiVOKvbMPCAjqomqpI7INQiy5NhOP+9jIF8I2Lv9hw9lk7o90VhUXpHIuuhPPBUQujDoteBjxiMYGI+Fb2cw6SJQLx14WLPern8zzrFpJZ1oubejA79mEiJLxuwYolrB6fav8pN X-Microsoft-Antispam-PRVS: <CY4PR06MB2472EE1A3D829B87F51A19ACF80C0@CY4PR06MB2472.namprd06.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(158342451672863); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123562025)(20161123560025)(20161123564025)(20161123555025)(6072148); SRVR:CY4PR06MB2472; BCL:0; PCL:0; RULEID:; SRVR:CY4PR06MB2472; X-Microsoft-Exchange-Diagnostics: 1; CY4PR06MB2472; 4:xcS3LjyI3yRFUgfZ64mC3bCFB1tRf42Z9lIp0YjptCK5RKCsgLigU2fIQT7y2si8zhL3wtoSlxuyuayUNi9Ov2wDLON8ljkwcaMDmBIOrKC4HDDuA8UCv+XzonsPdCBm3Q0dW/GKdNxH9CUbRVDZtPOGTXMbkbEE8D3mS0chzWWfKZDbq6gvQxcWsAs8GG7XUKGHzW8pywZnbouXnIJUKtosHYIbDJJWH5Jjy54N2Wln/x7hTPV+yvGF68NdoGX9sqSIWpmKkSRoNF5Aj9MhBPhRW8vTRenkGAS3UTx2MbY0LDT2Sfv/Dry8cNqqlO+vCkWQzPn7BYmtzjAuattKo8lXB3etoCf3neZ6xDBCkHY86PidxrF/YF7Kvc5lIlfZ/J9HglU2E88yEgv0eS03Z+WG2WgyMrlraOU1qYt0ZGnZ7qcJG+Fd/zoo+Cf9YrPto9cvyx6yr2Uxs0zM/pOcVR/RBIki0N0JcQBB8u5aRE2zKqw7KN0xSge1UVFRCjts2pQsF+KYm4ZiewX1xnLGBbTfiJ9e5OloEsec7JTlH5JELpv98tcehzMp4VFdHB/MxNryjOQCmfBY65ft6yRHY/XEs7mr2F3UbrrPGUcROjYgEmJ+M+cU2Q/kWZK45kuBuZLf4iIrZPnRcVF2kjkVJVuKEmJnfYJnA/dl78wDFNjZpExLce2KaV8tzc0UFH44Y2ABtyout/OloXf6f3b0vOvrQnR/f0N0y1w7lu5wb3tCp8Q+z8YHcBKF1xW6J9jk3/s5IyqgBdHmH6iv1noIXg== X-Forefront-PRVS: 0270ED2845 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39840400002)(39400400002)(39410400002)(39850400002)(39450400003)(305945005)(189998001)(2950100002)(5003940100001)(6666003)(7736002)(86152003)(6512007)(2876002)(6506006)(6486002)(36756003)(5660300001)(53936002)(25786009)(38730400002)(76176999)(50466002)(81166006)(8676002)(50226002)(1076002)(6116002)(66066001)(42186005)(2906002)(50986999)(47776003)(86362001)(3846002)(15760500002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR06MB2472; H:gouda.nowheycreamery.com.nowheycreamery.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR06MB2472; 23:ruYBkyrssOMWux3+f69zy+9+YdI/bjj239aTxtq+s?= =?us-ascii?Q?BJ7dvQHhMtHF5Y+bMk2Ot+rSMdV2f9AMAui6FBA5wnYjWr+F4wBo1D5ED+t8?= =?us-ascii?Q?xJmQLN1JmAwPw6WUUFLy+7tNwzO1Hyg5mNvVHvyTUwjHIGQ3bJTxE4Fqdtpy?= =?us-ascii?Q?kFwWLxyCMLbtkMLYJMgfTp6thj9jM1vScYWssLBqIajjF0Qr6PD031PdtSGT?= =?us-ascii?Q?e5nvNIxH6sSP9gs4CVbW2OzNhlLWRaHDvWG48Wk8kNcbApYVL3qbikrs1GYp?= =?us-ascii?Q?UtOITjbweIPzW8TS6cQrhBa012LZ5GMvTGM5njO1FDJFE63lVpjJTwwNSRCp?= =?us-ascii?Q?HKfhGgaX1DwrCUjxJFAWThI1q6wURbBew9s4n9pKPIteS6x65Z8t5qrLNyrI?= =?us-ascii?Q?7tkhJdF53gKtPzkohBYhVe6Cf8hWEUE4TYaexzQlAp0TifsuErQ8y5kp2qn+?= =?us-ascii?Q?p8fmNoVEhQ0+KnZxHg0PE6e9T8bAFotgXko4gU7KFEmEhOrdZJvZ29ctoro/?= =?us-ascii?Q?rBX1a1unL/rVWYlMQHljOEwuJ5xH5q/DyJUnM9ndQQJxFSIigq1wIzOi1fFX?= =?us-ascii?Q?gd3Mdr62nlqhG5egDQeIKJkC1whUi5Z/yO6GwZf4PCjxJafwW1iaX9KE2qcP?= =?us-ascii?Q?CAC0S+TV6O/cr5P3KsXtUpuaUqHYVT4F0E+kxjta9iPThWOtrYt7ALry8Ijz?= =?us-ascii?Q?pbQwdkqYyh+BgnxvI4fVv2OPogPCK7LUKONoOWz/DLGECW1hRJzSWqXdAWwP?= =?us-ascii?Q?2trTqOOGZ47qj8UP+Ip0FDPejwJrMYxNoBTDt/ExhH44mAniaaP/EtG5+vnO?= =?us-ascii?Q?Cp0JDCfp+MlsFXVodqgHqt5+WDaZhBEZAtJvKE/MKNzfuwezcB1amYdmVOV5?= =?us-ascii?Q?ah1Cqqik+V9J0QZJP6586C4yyeHDiBZJ83hB7RvEZodJRSgSqw91s3FsP7Nc?= =?us-ascii?Q?lgCnO0TLImtF/iTJ9AB3Q5XNc+qd0b75lUejS81GoqoPh0npki/fSvrkkZ5x?= =?us-ascii?Q?is=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR06MB2472; 6:p2y1dKeEU0ko0yjmt6O0e7wVopDlDU1JNYQo/QfppDu7jlBucDoqVnEghxUfO2yEgcSsIulhx1bhI5vUMDC8baEAnB6TSbWMCehd6+x/oPlk3dgtuXLDaBKZKybjGFRwXyLW/Pj5gMYY0YJ085uvcXWIzQ767MODJp5WVm3YXTj412Gypqoe7XMv+PwUX3x3tMuZ121WMIZ9LVQ+UVFjnYUlhZXMtLx3xbLtF3R50cdmsduGHE3DamiOk8+nXQ/SIpVejJ2iXqNEalPiBA5hkUB64Sjm5FAH/b3D4dwRPo4HMKutUfq4H4fdPvrthGashxa8zSVzJAE80ib4TLMUWNqRkbB9wbHyBYFwR5JiP4CeHt1o28qWhCLrKv9yU0sclmTm0HPl1LWxix77gTf1zOEqeyixJkVrWPpoW3EU8q0ZNpQ5BNeH51CsQIYIKi6NrTvNMxEBNzg8uZjkfZ83pQ==; 5:TXufP0HzBtNFX6096TZqxZh6BYEOewEAr2zO560F82ovOX/ZBYJ2SfSwuXCR3itm7IYGMLLbOwUjmp8rN+wjydggB0wI813IQnIr+pMKU9KUJUORvypCSwJvYVrqnxezZWQt4suBiWCb1waJETegkQ==; 24:ciG7cVN88Xw0IV2zenE00ByJj+jLPLiLSAvnMGnvtrJpXoo4Hf0l5kni5mqSnVtIgDp1G6VM0x4WUxu6tqGIAOtTtdqcoLQTw8qWHpLYzLs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR06MB2472; 7:XSBeCbPLNoLs96mrwHt/F7GtBnDItfIR/1xHLZPcPPCTG/XcPjh0wXD3saHHKSUrW/tLLb51h1BwiKfMnM/xAPUIQ3378ZWwZl/cLiU2RT262HjzUjaeoDGECUP4Ym5Xw8pmSumkeEO/K1lR+ydJGPHV+aakFpaewt0Gn1tmfp3jJFd58UiHt5Hv/dgo20pylnL2RHdmQ8QjTeL/pHJJ3TogvuyyEAZu4ec6ZXqRA3nTod8+Y0KxjsOJREoYs9O4ho8lWfVhwh271UK5Bl/aHsywsdflK+KcbBKrE6GXHa0NToBt89yk2zHQFH+luKyOjJ4db3MzSFQPlMy6vgVhTA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2017 18:15:54.6444 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR06MB2472 X-OriginatorOrg: netapp.com Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: <linux-nfs.vger.kernel.org> X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/fs/nfs/nfs4client.c b/fs/nfs/nfs4client.c index 8853c32eedf5..ce6f2ef62595 100644 --- a/fs/nfs/nfs4client.c +++ b/fs/nfs/nfs4client.c @@ -612,17 +612,8 @@ nfs4_check_serverowner_major_id(struct nfs41_server_owner *o1, struct nfs41_server_owner *o2) { if (o1->major_id_sz != o2->major_id_sz) - goto out_major_mismatch; - if (memcmp(o1->major_id, o2->major_id, o1->major_id_sz) != 0) - goto out_major_mismatch; - - dprintk("NFS: --> %s server owner major IDs match\n", __func__); - return true; - -out_major_mismatch: - dprintk("NFS: --> %s server owner major IDs do not match\n", - __func__); - return false; + return false; + return memcmp(o1->major_id, o2->major_id, o1->major_id_sz) == 0; } /*