From patchwork Wed Jul 19 20:53:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Dickson X-Patchwork-Id: 9853209 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5ED78602C8 for ; Wed, 19 Jul 2017 20:54:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 489B6286F3 for ; Wed, 19 Jul 2017 20:54:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3DB46286F5; Wed, 19 Jul 2017 20:54:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EE575286F3 for ; Wed, 19 Jul 2017 20:54:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754177AbdGSUyB (ORCPT ); Wed, 19 Jul 2017 16:54:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52570 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754180AbdGSUx7 (ORCPT ); Wed, 19 Jul 2017 16:53:59 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EA1CA80467 for ; Wed, 19 Jul 2017 20:53:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EA1CA80467 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=steved@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com EA1CA80467 Received: from steved.boston.devel.redhat.com (ovpn-122-174.rdu2.redhat.com [10.10.122.174]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E53117C14 for ; Wed, 19 Jul 2017 20:53:58 +0000 (UTC) From: Steve Dickson To: Linux NFS Mailing list Subject: [PATCH 05/11] nfsd.c: removed a few warnings Date: Wed, 19 Jul 2017 16:53:48 -0400 Message-Id: <20170719205354.10006-6-steved@redhat.com> In-Reply-To: <20170719205354.10006-1-steved@redhat.com> References: <20170719205354.10006-1-steved@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 19 Jul 2017 20:53:59 +0000 (UTC) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP nfsd.c:187:8: warning: this statement may fall through [-Wimplicit-fallthrough=] nfsd.c:213:8: warning: this statement may fall through [-Wimplicit-fallthrough=]nfsd.c:263:4: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Steve Dickson --- utils/nfsd/nfsd.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/utils/nfsd/nfsd.c b/utils/nfsd/nfsd.c index 2b38249..1d35658 100644 --- a/utils/nfsd/nfsd.c +++ b/utils/nfsd/nfsd.c @@ -198,6 +198,7 @@ main(int argc, char **argv) minorvers = 0; minorversset = minormask; } + break; case 3: case 2: NFSCTL_VERUNSET(versbits, c); @@ -220,6 +221,7 @@ main(int argc, char **argv) NFSCTL_MINORSET(minorvers, i); } else minorvers = minorversset = minormask; + break; case 3: case 2: NFSCTL_VERSET(versbits, c); @@ -261,8 +263,9 @@ main(int argc, char **argv) break; default: fprintf(stderr, "Invalid argument: '%c'\n", c); + /* FALLTHRU */ case 'h': - usage(progname); + usage(progname); /* usage does not return */ } }