diff mbox

[03/11] atomicio: removed a warning

Message ID 20170721163806.15803-4-steved@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Steve Dickson July 21, 2017, 4:37 p.m. UTC
atomicio.c:43:7: warning: this statement may fall through [-Wimplicit-fallthrough=]

Signed-off-by: Steve Dickson <steved@redhat.com>
---
 support/nfs/atomicio.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

J. Bruce Fields July 25, 2017, 8:51 p.m. UTC | #1
On Fri, Jul 21, 2017 at 12:37:58PM -0400, Steve Dickson wrote:
> atomicio.c:43:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
> ---
>  support/nfs/atomicio.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/support/nfs/atomicio.c b/support/nfs/atomicio.c
> index 5e760e6..9bf65b9 100644
> --- a/support/nfs/atomicio.c
> +++ b/support/nfs/atomicio.c
> @@ -42,6 +42,8 @@ ssize_t atomicio(ssize_t(*f) (int, void *, size_t), int fd, void *_s, size_t n)
>  		case -1:
>  			if (errno == EINTR || errno == EAGAIN)
>  				continue;
> +			break;
> +			/* FALLTHRU */

And I thought I was confused before!

--b.

>  		case 0:
>  			if (pos != 0)
>  				return pos;
> -- 
> 2.13.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/support/nfs/atomicio.c b/support/nfs/atomicio.c
index 5e760e6..9bf65b9 100644
--- a/support/nfs/atomicio.c
+++ b/support/nfs/atomicio.c
@@ -42,6 +42,8 @@  ssize_t atomicio(ssize_t(*f) (int, void *, size_t), int fd, void *_s, size_t n)
 		case -1:
 			if (errno == EINTR || errno == EAGAIN)
 				continue;
+			break;
+			/* FALLTHRU */
 		case 0:
 			if (pos != 0)
 				return pos;