From patchwork Tue May 8 16:15:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "J. Bruce Fields" X-Patchwork-Id: 10386465 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A6277602C2 for ; Tue, 8 May 2018 16:15:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 93959281D2 for ; Tue, 8 May 2018 16:15:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 884D828FF6; Tue, 8 May 2018 16:15:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4237E281D2 for ; Tue, 8 May 2018 16:15:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755365AbeEHQPa (ORCPT ); Tue, 8 May 2018 12:15:30 -0400 Received: from fieldses.org ([173.255.197.46]:50826 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754611AbeEHQP3 (ORCPT ); Tue, 8 May 2018 12:15:29 -0400 Received: by fieldses.org (Postfix, from userid 2815) id 20604AAA; Tue, 8 May 2018 12:15:29 -0400 (EDT) Date: Tue, 8 May 2018 12:15:29 -0400 From: "bfields@fieldses.org" To: Trond Myklebust Cc: "syzbot+4b98281f2401ab849f4b@syzkaller.appspotmail.com" , "syzkaller-bugs@googlegroups.com" , "anna.schumaker@netapp.com" , "davem@davemloft.net" , "linux-kernel@vger.kernel.org" , "linux-nfs@vger.kernel.org" , "jlayton@kernel.org" , "netdev@vger.kernel.org" , Chuck Lever Subject: Re: general protection fault in encode_rpcb_string Message-ID: <20180508161529.GD6151@fieldses.org> References: <20180417213308.GC18217@fieldses.org> <1524002074.63751.5.camel@hammer.space> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1524002074.63751.5.camel@hammer.space> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Apr 17, 2018 at 09:54:36PM +0000, Trond Myklebust wrote: > Yes, and we can probably convert it, and the other GFP_ATOMIC > allocations in the rpcbind client to use GFP_NOFS in order to improve > reliability. Chuck, I think the GFP_ATOMIC is unnecessary here as well? --b. --- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/sunrpc/xprtrdma/rpc_rdma.c b/net/sunrpc/xprtrdma/rpc_rdma.c index e8adad33d0bb..de90c6c90cde 100644 --- a/net/sunrpc/xprtrdma/rpc_rdma.c +++ b/net/sunrpc/xprtrdma/rpc_rdma.c @@ -228,7 +228,7 @@ rpcrdma_convert_iovs(struct rpcrdma_xprt *r_xprt, struct xdr_buf *xdrbuf, /* XXX: Certain upper layer operations do * not provide receive buffer pages. */ - *ppages = alloc_page(GFP_ATOMIC); + *ppages = alloc_page(GFP_NOFS); if (!*ppages) return -EAGAIN; }